-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Implement and stabilize the paper canvas pane strip #1637
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
lawrencecchen
wants to merge
40
commits into
main
Choose a base branch
from
issue-1221-paper-window-manager-layout
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 7 commits
Commits
Show all changes
40 commits
Select commit
Hold shift + click to select a range
6892147
Replace vendor bonsplit package with local PaneKit
lawrencecchen 9f728d8
Add paper-canvas pane layout engine
lawrencecchen 2879bbb
Persist and restore paper canvas layouts
lawrencecchen d28a8b0
Fix paper canvas restore focus mapping
lawrencecchen 0edf0e9
Make paper canvas the default pane layout
lawrencecchen 43bd589
Implement and stabilize the paper canvas pane strip
lawrencecchen 7b57c2d
Pin GhosttyKit checksum for pane strip motion fix
lawrencecchen ad7d02f
Add pane strip UI tests to Xcode target
lawrencecchen e08a636
Keep pane strip UI harness alive under XCUITest
lawrencecchen 4a4e639
Relax pane strip UI bootstrap grace
lawrencecchen 044f287
Tighten pane-strip portal visibility sync
lawrencecchen 3dfef9c
Fix pane-strip terminal visibility during animated pane changes
lawrencecchen 1051815
Fix pane-strip UI test activation on CI
lawrencecchen 01deaad
test: cover paper pane-strip middle-close width stability
lawrencecchen a8de599
fix: prewarm pane strip focus reveal harness
lawrencecchen 0cc9db3
fix: stabilize pane strip ui test launch
lawrencecchen 60495a1
fix: relax pane strip runtime launch readiness
lawrencecchen 25e846a
test: stabilize pane strip motion activation
lawrencecchen c02f40a
Add pane-strip motion verification coverage
lawrencecchen e100603
Fix pane-strip browser sync and UI test launch
lawrencecchen cca0db2
test: assert pane strip terminal visibility on screen
lawrencecchen 73aab33
Add pane-strip regression for browser split blanking source terminal
lawrencecchen d6dd3a8
Keep browser and terminal portals synced during pane-structure changes
lawrencecchen 21ee3bb
Stabilize pane-strip UI test app activation
lawrencecchen 28a5022
test: stop priming pane-strip startup terminal
lawrencecchen a654d96
fix: bootstrap blank pane-strip terminals when visible
lawrencecchen b6ef23a
fix: tick ghostty during terminal bootstrap refresh
lawrencecchen 85fc810
Refresh blank terminals after activation
lawrencecchen 468122b
Stabilize E2E UI test logging
lawrencecchen edc6dba
Add pane-strip regressions for blank hosted terminals
lawrencecchen 5098653
Replay hosted terminal visibility after surface creation
lawrencecchen 9b7f64d
Make pane-strip motion harness use real shortcut flow
lawrencecchen daa8b5b
Upload xcresult from E2E runs
lawrencecchen 8dadf89
test: reproduce pane strip late-activation blank terminal
lawrencecchen 2980fd4
fix: replay pane portal recovery after app activation
lawrencecchen 7214bed
fix: make pane strip late activation explicit
lawrencecchen a0e32b2
test: expose pane strip cold-start regression
lawrencecchen f2774ce
fix: bootstrap pane strip terminals on real host readiness
lawrencecchen 5629437
fix: add explicit pane-strip motion diagnostics init
lawrencecchen ffa9d54
fix: keep pane strip browsers aligned with pane motion
lawrencecchen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| // swift-tools-version: 5.9 | ||
|
|
||
| import PackageDescription | ||
|
|
||
| let package = Package( | ||
| name: "PaneKit", | ||
| platforms: [ | ||
| .macOS(.v14) | ||
| ], | ||
| products: [ | ||
| .library( | ||
| name: "PaneKit", | ||
| targets: ["PaneKit"] | ||
| ), | ||
| ], | ||
| targets: [ | ||
| .target( | ||
| name: "PaneKit", | ||
| dependencies: [], | ||
| path: "Sources/PaneKit" | ||
| ), | ||
| .testTarget( | ||
| name: "PaneKitTests", | ||
| dependencies: ["PaneKit"], | ||
| path: "Tests/PaneKitTests" | ||
| ), | ||
| ] | ||
| ) |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
Repository: manaflow-ai/cmux
Length of output: 335
Fix incomplete
PaneKitlinking inGhosttyTabstarget.PaneKitis declared inpackageProductDependenciesbut is missing from the Frameworks build phase and has noPBXBuildFileentries. UnlikeSparkle,Sentry,PostHog, andMarkdownUI, the framework is not fully wired up. Re-addingPaneKitto the target in Xcode will regenerate the required build file entries.🤖 Prompt for AI Agents