Skip to content

- moved mg1 implementation into correctly named manufacturer folder#15274

Open
Elektraglide wants to merge 4 commits into
mamedev:masterfrom
Elektraglide:move_mg1_to_whitechapel
Open

- moved mg1 implementation into correctly named manufacturer folder#15274
Elektraglide wants to merge 4 commits into
mamedev:masterfrom
Elektraglide:move_mg1_to_whitechapel

Conversation

@Elektraglide
Copy link
Copy Markdown
Contributor

No description provided.

@happppp
Copy link
Copy Markdown
Member

happppp commented Apr 27, 2026

This doesn't compile, you can see CI complain about wrong include guard. And you forgot to change mame.lst.
If these files are going to be moved, mg1_kbd.* is a better filename than kbd.*

@Elektraglide
Copy link
Copy Markdown
Contributor Author

This doesn't compile, you can see CI complain about wrong include guard. And you forgot to change mame.lst. If these files are going to be moved, mg1_kbd.* is a better filename than kbd.*

Well they do compile, they just fail the python checks.. But yes, will fix.

- renamed to mg1_kbd.[ch]
@cuavas
Copy link
Copy Markdown
Member

cuavas commented Apr 28, 2026

It's still a single-system project. Are there other Whitechapel things that will end up there, or is this something that should go in a "bucket" project?

@Elektraglide
Copy link
Copy Markdown
Contributor Author

It's still a single-system project. Are there other Whitechapel things that will end up there, or is this something that should go in a "bucket" project?

Yes, whitechapel made other workstations. But mainly just after consistent naming for easier searching.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants