GitTag, cliente github - Projeto de seleção Magrathea#11
Open
peterbrendel wants to merge 94 commits intomagrathealabs:masterfrom
Open
GitTag, cliente github - Projeto de seleção Magrathea#11peterbrendel wants to merge 94 commits intomagrathealabs:masterfrom
peterbrendel wants to merge 94 commits intomagrathealabs:masterfrom
Conversation
Bumps [elliptic](https://github.com/indutny/elliptic) from 6.5.2 to 6.5.3. - [Release notes](https://github.com/indutny/elliptic/releases) - [Commits](indutny/elliptic@v6.5.2...v6.5.3) Signed-off-by: dependabot[bot] <support@github.com>
Bumps [websocket-extensions](https://github.com/faye/websocket-extensions-node) from 0.1.3 to 0.1.4. - [Release notes](https://github.com/faye/websocket-extensions-node/releases) - [Changelog](https://github.com/faye/websocket-extensions-node/blob/master/CHANGELOG.md) - [Commits](faye/websocket-extensions-node@0.1.3...0.1.4) Signed-off-by: dependabot[bot] <support@github.com>
Bumps [http-proxy](https://github.com/http-party/node-http-proxy) from 1.18.0 to 1.18.1. - [Release notes](https://github.com/http-party/node-http-proxy/releases) - [Changelog](https://github.com/http-party/node-http-proxy/blob/master/CHANGELOG.md) - [Commits](http-party/node-http-proxy@1.18.0...1.18.1) Signed-off-by: dependabot[bot] <support@github.com>
update to typescript + mongoose
Fix on import
…nd_yarn/frontend/http-proxy-1.18.1 Bump http-proxy from 1.18.0 to 1.18.1 in /frontend
…nd_yarn/frontend/websocket-extensions-0.1.4 Bump websocket-extensions from 0.1.3 to 0.1.4 in /frontend
…nd_yarn/frontend/elliptic-6.5.3 Bump elliptic from 6.5.2 to 6.5.3 in /frontend
Defined navbar style
Added Cards style
Card style changed
…be a directory and end with a /
…be a directory and end with a /
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Algumas considerações (+as mesmas que estão no readme)
No front faltou muita organização no projeto. Fui aprendendo enquanto fazia e não quis voltar atrás.
Tenho noção que falta testes. Tentei implementar no back, valeu @VGasparini pela ajuda, mas tive muita dificuldade com jest e mongo. Ainda mais com a injeção de dependências, não fazia ideia de como mockar os models... Só um breve desabafo.
No back a estrutura ficou um pouco melhor, embora também fui aprendendo enquanto fazia. Comecei só com express, mas decidi utilizar o framework Nest. Ele ajudou bastante na arquitetura, mas eu consegui bagunçar o services de qualquer maneira :P.
Curti muito desenvolver esse projeto (embora tenha ficado parado por meses), aprendi muita coisa quando foquei em desenvolver. Valeu pela oportunidade!
A usabilidade não ficou boa, sofri pra conseguir deixar o sistema funcional com React. A dica é que as ações com tags são executadas após pressionar Enter e tirar o mouse da tag remove o foco dela.
O que falta no back (na minha visão)
O que falta no front