Call update after setting opacity#624
Open
Brayozin wants to merge 1 commit into
Open
Conversation
## Summary
`setOpacity` sets `_opacity` but never schedules a repaint, so opacity
changes have no visible effect until something else triggers one.
This adds the missing `update()` call.
In a related fix to the QML fork (qmltermwidget), I also moved
`setOpacity` to `public slots:` so it can be called directly from QML
and connected to signals. I didn't include that here since qtermwidget
is a pure C++ widget and the existing placement in `public:` is fine.
## Test plan
- [ ] Call `setOpacity()` with a sub-1.0 value and confirm the terminal
background renders semi-transparent immediately, without needing
any other event to trigger a repaint
- [ ] Confirm full-opacity (`1.0`) rendering is unchanged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
setOpacitysets_opacitybut never schedules a repaint, so opacity changes have no visible effect until something else triggers one. This adds the missingupdate()call.In a related fix to the QML fork (Swordfish90/qmltermwidget#48)), I also moved
setOpacitytopublic slots:so it can be called directly from QML and connected to signals. I didn't include that here since qtermwidget is a pure C++ widget and the existing placement inpublic:is fine.Test plan
setOpacity()with a sub-1.0 value and confirm the terminal background renders semi-transparent immediately, without needing any other event to trigger a repaint1.0) rendering is unchanged