Fix fullscreen landscape video player crash#503
Open
kejml wants to merge 2 commits into
Open
Conversation
Owner
|
Sleduj hlavně performance, nelíbí se mi moc to předělání posthtml na stateful.. |
Contributor
Author
|
Jo, ta se mi přesně zdá, že trpí. Nedělal jsem přímý srovnání, ale pocitově mi to přijde trochu línější. Zkusím ho výhledově posunout k jinýmu řešení. Původně zkoušel ještě něco jinýho, ale to k cíli nevedlo. |
By default, chewie allow also portraitDown after exiting fullscreen mode
Contributor
Author
|
@lucien144 Tak jsem z něj dostal i méně invazivní fix. Neznám flutter tak dobře abych posoudil, jestli si s tím reasoningem nevymýšlí, ale samotný problém to řeší. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #418, #80
Cela investigace je z rukou Claude, kterymu jsem podstrcil errory z konzole, Je to celkem velka zmena - nevim, jestli to nebude mit nejaky necekany side effecty, ale problemy s videem to resi. Budu ten build chivli testovat