feat(color): add dark/light dual-theme config support#1219
Open
hugoh wants to merge 1 commit into
Open
Conversation
Allow specifying separate theme files for dark and light terminal
backgrounds:
color:
theme:
dark: my-dark-colors
light: my-light-colors
Either key is optional; omitting falls back to the built-in default
for that mode. Existing string values (default, custom, legacy path)
are unchanged.
Mode is determined by TERM_BACKGROUND=light (unset → dark). Resolves:
TODO(zwpaper): check terminal color and return light or dark
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow specifying separate theme files for dark and light terminal backgrounds:
Either key is optional; omitting falls back to the built-in default for that mode. Existing string values (default, custom, legacy path) are unchanged.
Mode is determined by TERM_BACKGROUND=light (unset → dark). Resolves: TODO(zwpaper): check terminal color and return light or dark
I kept the detection logic with TERM_BACKGROUND to the minimum.
TODO
cargo fmtUpdate README (if applicable)Update config sample file indoc/samples(if applicable)Update icon sample file indoc/samples(if applicable)Update color sample file indoc/samples(if applicable)