-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Typscript version and upgrade #226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
muka
wants to merge
13
commits into
localtunnel:master
Choose a base branch
from
muka:feat/upgrade_ts
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
fc9334c
migrate to ts. Upgrade deps
lc-spxl 288c2db
add stylistic
lc-spxl e45db35
review tests
lc-spxl 99730cb
upgrade logging
lc-spxl ddc6b20
add PR localtunnel/server#118
lc-spxl 4acfb45
add PR localtunnel/server#116
lc-spxl ec10aac
add bin to package.json
lc-spxl cbbbce5
add PR localtunnel/server#154
lc-spxl 2a41923
missing secret opt
lc-spxl 5bda249
update readme
lc-spxl 938e335
expose js version as bin
lc-spxl 048dde7
update Dockerfile
lc-spxl c27a120
add PR localtunnel/server#225
lc-spxl File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,3 @@ | ||
| .git | ||
| node_modules | ||
| build |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,2 @@ | ||
| LOG_LEVEL=debug | ||
| DEBUG=localtunnel* |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,2 @@ | ||
| node_modules | ||
| build |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| { | ||
| // See https://go.microsoft.com/fwlink/?LinkId=827846 to learn about workspace recommendations. | ||
| // Extension identifier format: ${publisher}.${name}. Example: vscode.csharp | ||
| // List of extensions which should be recommended for users of this workspace. | ||
| "recommendations": [ | ||
| "dbaeumer.vscode-eslint" | ||
| ], | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| { | ||
| "[typescript]": { | ||
| "editor.defaultFormatter": "dbaeumer.vscode-eslint" | ||
| }, | ||
| "eslint.useFlatConfig": true, | ||
| "eslint.workingDirectories": [ | ||
| "src" | ||
| ], | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,13 +1,28 @@ | ||
| FROM node:10.1.0-alpine | ||
| FROM node:22 AS build | ||
|
|
||
| WORKDIR /app | ||
|
|
||
| COPY package.json /app/ | ||
| COPY yarn.lock /app/ | ||
| COPY package-lock.json /app/ | ||
|
|
||
| RUN yarn install --production && yarn cache clean | ||
| RUN npm install | ||
|
|
||
| COPY . /app | ||
| COPY ./src /app/src | ||
| COPY ./bin /app/bin | ||
| COPY ./tsconfig.json /app | ||
|
|
||
| ENV NODE_ENV production | ||
| ENTRYPOINT ["node", "-r", "esm", "./bin/server"] | ||
| RUN npm run build | ||
|
|
||
| FROM node:22-alpine | ||
|
|
||
| COPY --from=build /app/bin /app/bin | ||
| COPY --from=build /app/build /app/build | ||
| COPY --from=build /app/package.json /app/ | ||
| COPY --from=build /app/package-lock.json /app/ | ||
|
|
||
| WORKDIR /app | ||
|
|
||
| RUN npm install --production | ||
|
|
||
| ENV NODE_ENV=production | ||
| ENTRYPOINT ["node", "./bin/server.js"] | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| #!/usr/bin/env node | ||
| import "../build/src/bin/server.js" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| // @ts-check | ||
|
|
||
| import eslint from '@eslint/js'; | ||
| import mochaPlugin from "eslint-plugin-mocha"; | ||
| import tseslint from 'typescript-eslint'; | ||
| import stylisticTs from '@stylistic/eslint-plugin-ts' | ||
|
|
||
| export default tseslint.config( | ||
| mochaPlugin.configs.flat.recommended, | ||
| eslint.configs.recommended, | ||
| tseslint.configs.recommended, | ||
| { | ||
| plugins: { | ||
| '@stylistic/ts': stylisticTs | ||
| }, | ||
| rules: { | ||
| "@typescript-eslint/no-unused-vars": "warn", | ||
| '@stylistic/ts/indent': ['error', 2], | ||
| }, | ||
| }, | ||
| ); |
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice