Skip to content

Including a list of available allocators when allocator not found #1064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kab163 wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

Including a list of available allocators when allocator not found #1064

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8574398
initial fix for available allocators error messages
kab163 Apr 7, 2026
6470d48
testing
kab163 Apr 23, 2026
32d6485
Merge branch 'develop' of github.com:llnl/Umpire into task/available-…
kab163 May 4, 2026
e2bc548
testing new method for getAllocatorInformation
kab163 May 4, 2026
173ffdf
removing changes made for testing
kab163 May 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/umpire/ResourceManager.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1093,9 +1093,8 @@ int ResourceManager::getNextId() noexcept
std::string ResourceManager::getAllocatorInformation() const noexcept
{
std::ostringstream info;

for (auto& it : m_allocators_by_name) {
info << *it.second << " ";
for (const auto& name : resource::MemoryResourceRegistry::getInstance().getResourceNames()) {
Comment thread
kab163 marked this conversation as resolved.
info << name << ' ';
}

return info.str();
Expand Down
14 changes: 14 additions & 0 deletions tests/unit/resource_manager_tests.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,20 @@ TEST(ResourceManager, getAllocatorByName)
ASSERT_THROW(rm.getAllocator("BANANA"), umpire::runtime_error);
}

TEST(ResourceManager, getAllocatorByNameErrorListsAvailableAllocators)
{
auto& rm = umpire::ResourceManager::getInstance();

try {
UMPIRE_USE_VAR(rm.getAllocator("BANANA"));
FAIL() << "Expected getAllocator to throw";
} catch (const umpire::runtime_error& e) {
const std::string message{e.what()};
EXPECT_NE(message.find("Available allocators:"), std::string::npos);
EXPECT_NE(message.find("HOST"), std::string::npos);
}
}

TEST(ResourceManager, getAllocatorById)
{
auto& rm = umpire::ResourceManager::getInstance();
Expand Down
Loading