Annotate kernels separately#695
Draft
michaelmckinsey1 wants to merge 6 commits into
Draft
Conversation
Contributor
Author
|
made a draft because need to add different types to these regions so we can filter them with caliper |
artv3
reviewed
Jun 29, 2026
| RP_CALI_MARK_END(RP_CALI_REGION(ENERGY_1)); | ||
|
|
||
| RP_CALI_MARK_BEGIN(RP_CALI_REGION(ENERGY_2)); | ||
| RAJA::forall< RAJA::cuda_exec<block_size, async> >( res, |
Member
There was a problem hiding this comment.
@michaelmckinsey1 , why not use just use RAJA's kernel naming capability here? Example...
RAJA::forall<RAJA::cuda_exec<256>>(
range,
RAJA::Name("VectorAddKernel"), // <-- Kernel Name injected here
[=] RAJA_DEVICE (int i) {
c[i] = a[i] + b[i];
}
);
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
type=function->type=subkernelExamples
Polybench_JACOBI_1Dhas one launch per rep forpoly_jacobi_1D_1and one forpoly_jacobi_1D_2. So its tree will now profile each separately:POLYBENCH_FLOYD_WARSHALL,HALO_PACKING,HALO_EXCHANGEall have variable amount of launches, so we will append_kinstead of adding k regions to the treeAll kernels with only 1 launch per rep are unchanged.