Skip to content

cmake: Add argument to RAJA add code checks macro#1972

Open
johnbowen42 wants to merge 5 commits into
developfrom
cmake/bowen/add-arguments-to-style-func
Open

cmake: Add argument to RAJA add code checks macro#1972
johnbowen42 wants to merge 5 commits into
developfrom
cmake/bowen/add-arguments-to-style-func

Conversation

@johnbowen42

@johnbowen42 johnbowen42 commented Jan 8, 2026

Copy link
Copy Markdown
Contributor

This simple PR add arguments to the raja_add_code_checks macro rather than manually setting directories within the function definition. As discussed offline between @artv3 and myself, this allows RAJAPerf to include the macro and reuse it to format RAJAPerf files.

@johnbowen42 johnbowen42 requested review from a team and artv3 January 8, 2026 23:06
@rhornung67

rhornung67 commented Jan 8, 2026

Copy link
Copy Markdown
Member

@johnbowen42 thanks for adding this. After the benchmarking stuff is rolled out, we will need to discuss how to apply formatting to RAJA Perf, many opportunities to make complicated code unreadable 😄

@smithsg84 smithsg84 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@rhornung67 rhornung67 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @johnbowen42

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants