Complete implementations of GPU basic reducer constructor test#1474
Conversation
|
@rchen20 please don't merge this. Something is more broken here than it is on develop. |
@rhornung67 Comparing the Tioga output from #1476 and this PR, they are roughly the same, except the failing test now passes. What occurs is that the ROCM/5.1.1 tests build, run, and pass with the linker warning spew. In the subsequent ROCM/5.2.3 build, the linker spew exceeds the log limit. This PR does not seem to affect the Tioga pipeline's excessive readelf warnings. |
|
Merged in #1434 and working. Thank you! |
|
@rhornung67 I think this could be merged into develop regardless of the CI branch. This PR addresses a bug affecting others (and develop). |
|
Right. Robert will merge it. Later today, I'm going to look into the Spack config file that is generated for the build space issues. When I manually run CMake with the ROCm versions used on corona and tioga and compile, I don't see any of those warnings. I have a hunch that we may need to fiddle with the Spack spec for those builds. |
Summary