Skip to content

Use maintain-resolution as the default video degradation preference #1106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hiroshihorie merged 2 commits into from
Jun 6, 2026
Merged

Use maintain-resolution as the default video degradation preference #1106

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7edb595
Align video degradation default with Swift
hiroshihorie Jun 5, 2026
6045ef2
Add change entry for degradation default
hiroshihorie Jun 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .changes/video-degradation-default
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
patch type="fixed" "Use maintain-resolution as the default video degradation preference for local video publishing"
21 changes: 2 additions & 19 deletions lib/src/participant/local.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -386,10 +386,7 @@ class LocalParticipant extends Participant<LocalTrackPublication> {
}

if ([TrackSource.camera, TrackSource.screenShareVideo].contains(track.source)) {
final degradationPreference = publishOptions.degradationPreference ??
getDefaultDegradationPreference(
track,
);
final degradationPreference = publishOptions.degradationPreference ?? DegradationPreference.maintainResolution;
await track.setDegradationPreference(degradationPreference);
}

Expand Down Expand Up @@ -487,10 +484,7 @@ class LocalParticipant extends Participant<LocalTrackPublication> {
}

if ([TrackSource.camera, TrackSource.screenShareVideo].contains(track.source)) {
final degradationPreference = publishOptions.degradationPreference ??
getDefaultDegradationPreference(
track,
);
final degradationPreference = publishOptions.degradationPreference ?? DegradationPreference.maintainResolution;
await track.setDegradationPreference(degradationPreference);
}

Expand Down Expand Up @@ -593,17 +587,6 @@ class LocalParticipant extends Participant<LocalTrackPublication> {
await pub.dispose();
}

DegradationPreference getDefaultDegradationPreference(LocalVideoTrack track) {
// a few of reasons we have different default paths:
// 1. without this, Chrome seems to aggressively resize the SVC video stating `quality-limitation: bandwidth` even when BW isn't an issue
// 2. since we are overriding contentHint to motion (to workaround L1T3 publishing), it overrides the default degradationPreference to `balanced`
final VideoDimensions dimensions = track.currentOptions.params.dimensions;
if (track.source == TrackSource.screenShareVideo || dimensions.height >= 1080) {
return DegradationPreference.maintainResolution;
}
return DegradationPreference.balanced;
}

/// Convenience method to unpublish all tracks.
Future<void> unpublishAllTracks({bool notify = true, bool? stopOnUnpublish}) async {
final trackSids = trackPublications.keys.toSet();
Expand Down
Loading