fix(voice): add timeout fallback to transcript segment aclose#6029
Merged
Conversation
_SegmentSynchronizerImpl.aclose() awaits the forwarding/speaking-rate tasks unconditionally. If a downstream output stalls, those awaits can hang and block segment rotation from installing a fresh impl. Add a timeout fallback: if the tasks don't drain in time, warn and cancel them so rotation always completes. Also stamp each impl with an id in the warning extras to tell a stuck impl from a fresh one in logs.
longcw
force-pushed
the
longc/fix-transcript-sync-rotation-deadlock
branch
from
d1c4726 to
2f8f310
Compare
longcw
changed the title
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
theomonnom
approved these changes
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_SegmentSynchronizerImpl.aclose()awaits the forwarding/speaking-rate tasks unconditionally. If a downstream output stalls, those awaits can hang and block segment rotation from installing a fresh impl, leavingTranscriptSynchronizer._implstuck closed.Add a timeout fallback: if the tasks don't drain in time, warn and cancel them so rotation always completes. Also stamp each impl with an id and include it in the warning extras, so a stuck impl can be told apart from a fresh one in logs.