Draft
Conversation
30a10aa to
c2a50b7
Compare
178d6e2 to
36da67d
Compare
36da67d to
ad24ee2
Compare
1fd959e to
dee8b90
Compare
db82590 to
5cc90a2
Compare
5cc90a2 to
ee9d562
Compare
64f18d0 to
6e7bf66
Compare
2d46a9b to
d5f42e0
Compare
d5f42e0 to
422fe9a
Compare
33ebf6a to
3708e99
Compare
3708e99 to
4ea4d0a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If able to, this layer will download the Node.js source and build if Node.js is not detected on system.
Node.js includes the Yarn and npm tools.
This approaches a zero-install workflow to allow users to immediately use the lsp layer to download and use language servers as needed, and also coc.nvim.
I also prefer to allow users the option of automatically building dependencies from source where possible, instead of them having to manually download binaries and read relevant installation documentation themselves.
Other changes:
Minor shortcomings:
Blocking Bug: There is a problem with AsyncRun being used within a vim-plug job. I need to resolve that problem before I can add this layer. I found a workaround involving a timer to wait until vim-plug had finished (re)loading the plugins (which broke AsyncRun). A proposed event in vim-plug will remove the need for this timer, waiting on that author.Contingent on: #500.