Skip to content

port nowplaying window#786

Merged
listen1 merged 4 commits intonextfrom
new-now-playing
Feb 5, 2022
Merged

port nowplaying window#786
listen1 merged 4 commits intonextfrom
new-now-playing

Conversation

@mikelxk
Copy link
Copy Markdown
Collaborator

@mikelxk mikelxk commented Feb 2, 2022

@Dumeng I tried to port your change in now playing window from #755 but there's this weird gap.
image
Do you have time to take a quick look?

Comment thread src/views/NowPlaying.vue Outdated
Comment thread src/views/NowPlaying.vue Outdated
@listen1
Copy link
Copy Markdown
Owner

listen1 commented Feb 5, 2022

make some modifications for now playing style

  • change now playing show animation time to 300ms, 500ms seems a little slow
  • move music cover closer to lryic column
  • fix lyric last line hide because placeholder height too small bug
  • change lyric placeholder height from 1/2 height to 1/3 height, because it seems too empty when song begins
  • smaller margin top of comment zone

@listen1 listen1 merged commit a5c9b83 into next Feb 5, 2022
@listen1 listen1 deleted the new-now-playing branch February 5, 2022 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants