Skip to content

Bugfix: VPC api call failures could cause deletion of all nodes #570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
akaokunc wants to merge 2 commits into
base: main
Choose a base branch
from
+112 −4
Open

Bugfix: VPC api call failures could cause deletion of all nodes #570

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0adb33b
Bugfix VPC api call failures could cause deletion of all nodes
akaokunc May 13, 2026
2fc95f7
Adding test for VPC API call failures
akaokunc May 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions cloud/linode/services/instances.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,8 +103,7 @@ func (nc *nodeCache) refreshInstances(ctx context.Context, client client.Client)
}
resp, err := GetVPCIPAddresses(ctx, client, vpcName)
if err != nil {
klog.Errorf("failed updating instances cache for VPC %s. Error: %s", vpcName, err.Error())
continue
return fmt.Errorf("failed updating instances cache for VPC %s: %w", vpcName, err)
}
for _, vpcip := range resp {
if vpcip.Address == nil {
Expand All @@ -115,8 +114,7 @@ func (nc *nodeCache) refreshInstances(ctx context.Context, client client.Client)

resp, err = GetVPCIPv6Addresses(ctx, client, vpcName)
if err != nil {
klog.Errorf("failed updating instances cache for VPC %s. Error: %s", vpcName, err.Error())
continue
return fmt.Errorf("failed updating instances cache for VPC %s: %w", vpcName, err)
}
for _, vpcip := range resp {
if len(vpcip.IPv6Addresses) == 0 {
Expand Down
110 changes: 110 additions & 0 deletions cloud/linode/services/instances_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -456,6 +456,116 @@ func TestMalformedProviders(t *testing.T) {
})
}

func TestRefreshInstancesVPCErrors(t *testing.T) {
ctx := t.Context()
ctrl := gomock.NewController(t)
defer ctrl.Finish()

c := mocks.NewMockClient(ctrl)

t.Run("returns error when GetVPCIPAddresses fails", func(t *testing.T) {
instances := NewInstances(c)
node := nodeWithProviderID(ccmUtils.ProviderIDPrefix + "123")

options.Options.VPCNames = []string{"test"}
VpcIDs["test"] = 1
defer func() {
options.Options.VPCNames = []string{}
delete(VpcIDs, "test")
}()

apiErr := fmt.Errorf("VPC API error")
c.EXPECT().ListInstances(gomock.Any(), nil).Times(1).Return([]linodego.Instance{
{ID: 123, Label: "test-instance"},
}, nil)
c.EXPECT().ListVPCIPAddresses(gomock.Any(), 1, gomock.Any()).Return(nil, apiErr)

_, err := instances.InstanceExists(ctx, node)
require.Error(t, err)
assert.ErrorContains(t, err, "failed updating instances cache for VPC test")
})

t.Run("returns error when GetVPCIPv6Addresses fails", func(t *testing.T) {
instances := NewInstances(c)
node := nodeWithProviderID(ccmUtils.ProviderIDPrefix + "123")

options.Options.VPCNames = []string{"test"}
VpcIDs["test"] = 1
defer func() {
options.Options.VPCNames = []string{}
delete(VpcIDs, "test")
}()

vpcIP := "10.0.0.2"
apiErr := fmt.Errorf("VPC IPv6 API error")
c.EXPECT().ListInstances(gomock.Any(), nil).Times(1).Return([]linodego.Instance{
{ID: 123, Label: "test-instance"},
}, nil)
c.EXPECT().ListVPCIPAddresses(gomock.Any(), 1, gomock.Any()).Return([]linodego.VPCIP{
{Address: &vpcIP, LinodeID: 123, VPCID: 1},
}, nil)
c.EXPECT().ListVPCIPv6Addresses(gomock.Any(), 1, gomock.Any()).Return(nil, apiErr)

_, err := instances.InstanceExists(ctx, node)
require.Error(t, err)
assert.ErrorContains(t, err, "failed updating instances cache for VPC test")
})

t.Run("does not update cache when GetVPCIPAddresses fails", func(t *testing.T) {
instances := NewInstances(c)
node := nodeWithProviderID(ccmUtils.ProviderIDPrefix + "123")

options.Options.VPCNames = []string{"test"}
VpcIDs["test"] = 1
defer func() {
options.Options.VPCNames = []string{}
delete(VpcIDs, "test")
}()

apiErr := fmt.Errorf("VPC API error")
c.EXPECT().ListInstances(gomock.Any(), nil).Times(1).Return([]linodego.Instance{
{ID: 123, Label: "test-instance"},
}, nil)
c.EXPECT().ListVPCIPAddresses(gomock.Any(), 1, gomock.Any()).Return(nil, apiErr)

_, err := instances.InstanceExists(ctx, node)
require.Error(t, err)

// Cache must not be stamped so the next call retries instead of
// serving the empty/stale data that caused the original node-deletion bug.
assert.True(t, instances.nodeCache.lastUpdate.IsZero(), "cache lastUpdate should remain zero after a failed refresh")
})

t.Run("does not update cache when GetVPCIPv6Addresses fails", func(t *testing.T) {
instances := NewInstances(c)
node := nodeWithProviderID(ccmUtils.ProviderIDPrefix + "123")

options.Options.VPCNames = []string{"test"}
VpcIDs["test"] = 1
defer func() {
options.Options.VPCNames = []string{}
delete(VpcIDs, "test")
}()

vpcIP := "10.0.0.2"
apiErr := fmt.Errorf("VPC IPv6 API error")
c.EXPECT().ListInstances(gomock.Any(), nil).Times(1).Return([]linodego.Instance{
{ID: 123, Label: "test-instance"},
}, nil)
c.EXPECT().ListVPCIPAddresses(gomock.Any(), 1, gomock.Any()).Return([]linodego.VPCIP{
{Address: &vpcIP, LinodeID: 123, VPCID: 1},
}, nil)
c.EXPECT().ListVPCIPv6Addresses(gomock.Any(), 1, gomock.Any()).Return(nil, apiErr)

_, err := instances.InstanceExists(ctx, node)
require.Error(t, err)

// Cache must not be stamped so the next call retries instead of
// serving the empty/stale data that caused the original node-deletion bug.
assert.True(t, instances.nodeCache.lastUpdate.IsZero(), "cache lastUpdate should remain zero after a failed refresh")
})
}

func TestInstanceShutdown(t *testing.T) {
ctx := t.Context()
ctrl := gomock.NewController(t)
Expand Down
Loading