charts: make honorTimestamps configurable for linkerd-proxy PodMonitor#15080
Merged
Conversation
bezarsnba
force-pushed
the
add-honortimestamps
branch
from
9f3e232 to
e44acbb
Compare
alpeb
reviewed
May 13, 2026
Member
alpeb
left a comment
alpeb
left a comment
There was a problem hiding this comment.
Thanks @bezarsnba , any reason why this wasn't applied to the control plane PodMonitor?
Also, you'll need to run go test ./... -update in order to update the test fixtures.
bezarsnba
force-pushed
the
add-honortimestamps
branch
from
00e6ba2 to
0f18845
Compare
**Why is this PR necessary?** In clusters with frequent pod restarts, Prometheus may drop scrapes due to duplicate timestamps reported by the exporter. Allowing honorTimestamps to be disabled lets Prometheus use scrape time instead, preventing those drops. **What does it do?** Adds an optional honorTimestamps field to the controller, proxy and serviceMirror PodMonitors in the linkerd-control-plane chart. The field is rendered only when set, preserving backward compatibility. **References:** N/A **Notes:** N/A Signed-off-by: bezarsnba <bezarsnba@gmail.com>
bezarsnba
force-pushed
the
add-honortimestamps
branch
from
0f18845 to
0f7c910
Compare
Contributor
Author
|
Thanks for the review @alpeb! Good catch — there was no particular reason, I just missed the control-plane PodMonitor. I've now extended Also ran |
alpeb
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When scraping linkerd-proxy metrics with Prometheus, samples are sometimes dropped due to duplicate timestamps with different values, producing warnings like:
Error on ingesting samples with different value but same timestamp scrape_pool=podMonitor/linkerd/linkerd-proxy
This is especially common in large clusters with frequent pod restarts and short scrape intervals, causing operational noise and alert fatigue. Add an optional
honorTimestampsfield to theproxyandserviceMirrorPodMonitor endpoints in the linkerd-control-plane Helm chart. When set tofalse, Prometheus uses the scrape time instead of exporter-provided timestamps, preventing duplicate timestamp drops while keeping backward compatibility for users who do not set the field.Usage:
Existing behavior is preserved when the field is not configured.
Fixes #14905
Signed-off-by: bezarsnba@gmail.com