[NPU, A3] Add NPU kernel support for A3 machines#1220
Draft
zheliuyu wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This work follows the roadmap in linkedin/Liger-Kernel#969. The goal is to exercise the NPU kernel on Atlas 800T A3 (64G) and report how the test suite behaves on that hardware.
Details
Why
attn_resfailed on A3The failure showed up as vector-core / ACL errors (e.g. 507035, device sync failing), not a normal atol/rtol mismatch.
attn_resuses wide masked loads along the feature dim (e.g.BLOCK_D = next_power_of_2(D)).D = 123withfloat32, so row pitch is123 × 4 = 492bytes—not 32B/64B-friendly for many vectorized paths on this stack, which can trigger vector-core faults for that lowering.d_strideas the real memory pitch, keepDfor math/masks, and slice/pad tensors so callers still see logicalD.Benchmark results for the 4 most frequently used kernels
Testing Done
make testto ensure correctnessmake checkstyleto ensure code stylemake test-convergenceto ensure convergence