[Benchmark] add benchmark for grpo_loss kernel#1216
Open
UserChen666 wants to merge 4 commits into
Open
Conversation
UserChen666
changed the title
UserChen666
changed the title
UserChen666
changed the title
Contributor
Author
|
@Tcc0403 could you please review this pr? |
Collaborator
|
We have an update on benchmark suite, please follow the latest https://github.com/linkedin/Liger-Kernel/blob/main/benchmark/README.md to ensure everything is up-to-date |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The original benchmar_grpo_loss.py is aiming to test chunked_loss/grpo_loss.py, so this Pr wants to add benchmark for ops/grpo_loss.py or some other grpo_loss kernels like _ascend/ops/grpo_loss.py.
Testing Done
make testto ensure correctnessmake checkstyleto ensure code stylemake test-convergenceto ensure convergence