Pack fill_gap into alpha_idx#1238
Merged
Merged
Conversation
taj-p
added
the
C-sparse-strips
LaurenzV
approved these changes
Sep 21, 2025
LaurenzV
left a comment
LaurenzV
left a comment
Collaborator
There was a problem hiding this comment.
It is a bit unfortunate that this reduces the number of alpha values that can be stored by a lot, but I doubt that we will exceed 2GB under normal circumstances.
|
|
||
| /// Sets the alpha index. | ||
| /// | ||
| /// Note that the largest value that can be stored in the alpha index is `u32::MAX - 1`, as the |
Collaborator
There was a problem hiding this comment.
Isn't it u32::MAX / 2 (or u32::MAX << 1)?
| .map(move |strip| { | ||
| let mut adjusted_strip = *strip; | ||
| adjusted_strip.alpha_idx += alpha_offset; | ||
| adjusted_strip.set_alpha_idx(adjusted_strip.alpha_idx().wrapping_add(alpha_offset)); |
Collaborator
There was a problem hiding this comment.
Do we really want a wrapping add here? Wouldn't it be better to just use normal add so that at least in debug mode it panics?
Contributor
Author
There was a problem hiding this comment.
Yes, you're right. Thank you - nice catch! Fixed in a217c0c
taj-p
commented
Sep 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1213
See #1206 (comment)
The main motivations for the packing are to:
Recordings andStripallocation