Put wgpu's default features behind a 'wgpu_default' feature flag#1229
Conversation
StT191
force-pushed
the
main
branch
2 times, most recently
from
669c873 to
d5215e4
Compare
There was a problem hiding this comment.
This looks good, thanks. There are a few minor details I'd like to see done differently; let me know if you want me to take over. I'd also like to get confirmation from Andrew that this won't cause issues, as it is technically a breaking change to Vello Hybrid.
Can you please also add this to the CHANGELOG. That changelog currently only covers the root "Vello" crate, so only needs to mention that change. I'd add it to the "changed" section. It is technically a breaking change, so let's mark it as such (even though it's very minor).
…feature inconsistency in vello_hybrid
Only whitespace, punctuation and ordering
DJMcNab
left a comment
DJMcNab
left a comment
There was a problem hiding this comment.
Thank you! I've pushed a few final tweaks.
Let me know if you are ready for this to land (i.e. if you have any comment on my tweaks).
I'll merge this soon if I don't hear from you.
DJMcNab
added
C-classic
I'm absolutely onboard with this. Great experience to get involved. |
3 participants
This PR enables users of
velloto disablewgpu's default features (see #1225). This is especially useful aswgpuallows enabling and disabling of all backends via feature flags since version25.0.0.The previous behavior is behind an new feature flag
wgpu_defaultthat is included invellos's default features so current users ofvellowho rely on them don't get surprised.