Remove unsafe from generated helpers and const-generic functions#244
Merged
Conversation
This is a lot less complex and scary than I feared it would be.
…t's not needed after all This reverts commit 284299f.
DJMcNab
approved these changes
Jun 17, 2026
DJMcNab
left a comment
DJMcNab
left a comment
Member
There was a problem hiding this comment.
Reviewing with whitespace hidden helps a lot here. I can approve that this only removes unsafes, without changing logic.
Shnatsel
added a commit
to Shnatsel/fearless_simd
that referenced
this pull request
Jun 17, 2026
Includes regenerated AVX-512 slide helpers for the same safety cleanup.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #236
Didn't even need to extend
kernel!to support const generics in the end.The only remaining
unsafeis now inload/store_interleavedwhich can be eliminated on x86 and WASM but not NEON. That's addressed separately in #245Fixes #124