Document the motivation for custom transmute wrappers#243
Merged
Conversation
They've grown to be more than just 'bytemuck at home'
LaurenzV
approved these changes
Jun 16, 2026
| // SPDX-License-Identifier: Apache-2.0 OR MIT | ||
|
|
||
| //! We have bytemuck at home | ||
| //! This all serves a small set of checked transmute and cast functions. |
Collaborator
There was a problem hiding this comment.
I think it would be better to keep a concise top-title (like "Transmuting between SIMD types and wrappers" and then start with the description in the next paragraph.
DJMcNab
reviewed
Jun 17, 2026
Comment on lines
+10
to
+11
| //! Unlike bytemuck, this verifies that sizes match at compile time, | ||
| //! so we won't accidentally ship always-panicking code even if it's not covered by tests. |
Member
There was a problem hiding this comment.
As I noted in #232, with bytemuck's 'must' functionality, this isn't really the case.
Shnatsel
added a commit
to Shnatsel/fearless_simd
that referenced
this pull request
Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
They've grown to be more than just 'bytemuck at home'