Conversation
|
Need to sort out commits |
Signed-off-by: Seonghyeon Cho <seonghyeoncho96@gmail.com>
Signed-off-by: Seonghyeon Cho <seonghyeoncho96@gmail.com>
Signed-off-by: Seonghyeon Cho <seonghyeoncho96@gmail.com>
65442a8 to
a329f31
Compare
Signed-off-by: Seonghyeon Cho <seonghyeoncho96@gmail.com>
a329f31 to
b4e359d
Compare
Signed-off-by: Seonghyeon Cho <seonghyeoncho96@gmail.com> Remove temp comment Signed-off-by: Seonghyeon Cho <seonghyeoncho96@gmail.com> Add deprecated comment Signed-off-by: Seonghyeon Cho <seonghyeoncho96@gmail.com> Add indent on imports Signed-off-by: Seonghyeon Cho <seonghyeoncho96@gmail.com> Add indent more Signed-off-by: Seonghyeon Cho <seonghyeoncho96@gmail.com>
Signed-off-by: Seonghyeon Cho <seonghyeoncho96@gmail.com>
`Type argument is not within its bounds: should be subtype of 'kotlin.Any'.`, etc Signed-off-by: Seonghyeon Cho <seonghyeoncho96@gmail.com>
b4e359d to
a03482b
Compare
This comment was marked as resolved.
This comment was marked as resolved.
|
I'll open this after #6457 gets merged and rebased |
|
Important Review skippedToo many files! 150 files out of 300 files are above the max files limit of 150. You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6456 +/- ##
============================================
- Coverage 74.46% 74.32% -0.14%
- Complexity 22234 23625 +1391
============================================
Files 1963 2120 +157
Lines 82437 88364 +5927
Branches 10764 11556 +792
============================================
+ Hits 61385 65679 +4294
- Misses 15918 17169 +1251
- Partials 5134 5516 +382 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
It seems like it doesn't work on JDK 8: I think we probably need to wait until we drop support for JDK 8. |
(Base: #6457)
Motivation:
jsr-305 is dormant and now JSpecify is recommended annotation sets for variety of static analyses (for now, it supports only nullness) and many open sources are moving to JSpecify (e.g. Spring Framework, Guava, ...)
Modifications:
com.linecorp.armeria.common.annotation.Nullable->org.jspecify.annotations.Nullablecom.linecorp.armeria.common.annotation.NonNullByDefault->org.jspecify.annotations.NullMarkedNote:
Since JSpecify's Nullable annotation is type-use annotation, placement of existing jsr-305 annotations are incompatible with JSpecify one, so following steps should be applied (ref: https://jspecify.dev/docs/using/#if-your-code-already-uses-jsr-305-annotations)
@Nullable Object[]->Object @Nullable []@Nullable Map.Entry<K, V>->Map.@Nullable Entry<K, V>Result: