tapchannel+itest: implement AuxCloseShape and cover the coop close fee baseline - #2091
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a regression test for cooperative close fee estimation when auxiliary outputs are present, ensuring that closing at the relay floor remains successful. It also adds helper functions closeAssetChannelWithFeeAndAssert and waitForClosePendingUpdate to facilitate testing channel closures with specific fee rates. Feedback suggests replacing the magic number 1000 with a named constant for better maintainability and improving the reliability of channel closure operations by using a longer timeout and applying it to the CloseChannel RPC call.
darioAnongba
changed the title
darioAnongba
force-pushed
the
test/chancloser-aux-outputs
branch
from
August 28, 2026 10:46
d25dda6 to
f087881
Compare
darioAnongba
changed the title
darioAnongba
marked this pull request as ready for review
August 28, 2026 10:51
|
@darioAnongba, remember to re-request review from reviewers when ready |
GeorgeTsagk
approved these changes
Aug 28, 2026
GeorgeTsagk
left a comment
GeorgeTsagk
left a comment
Member
There was a problem hiding this comment.
LGTM
pending LND PR and final go.mod replace
github-project-automation
Bot
moved this from 🏗 In progress
to 👀 In review
in Taproot-Assets Project Board
Bumps lnd to pull in the AuxCloseShape interface method (lightningnetwork/lnd#10969) and implements it: one P2TR entry per party with a non-zero asset balance. The close fee only affects the values of the asset outputs, never their number or script sizes. Also updates the lntest harness call to the NewNodeWatchOnly API.
darioAnongba
force-pushed
the
test/chancloser-aux-outputs
branch
from
August 28, 2026 15:02
f087881 to
d2d85bf
Compare
Closes an asset channel at the relay floor fee rate and asserts the close transaction confirms with the expected auxiliary output. A fee baseline that omits the aux output weight underprices the close transaction, which is then rejected by the mempool and the test times out waiting for the close.
darioAnongba
force-pushed
the
test/chancloser-aux-outputs
branch
from
August 28, 2026 16:23
d2d85bf to
5c2b5e6
Compare
github-project-automation
Bot
moved this from 👀 In review
to ✅ Done
in Taproot-Assets Project Board
jtobin
pushed a commit
that referenced
this pull request
Sep 2, 2026
tapchannel+itest: implement AuxCloseShape and cover the coop close fee baseline (cherry picked from commit af41397)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the tapd side of lightningnetwork/lnd#10969, which fixes the initial coop close fee baseline for channels with auxiliary close outputs, together with a regression itest.
AuxCloseShape implementation
AuxChanCloser.AuxCloseShapereturns the fee-independent shape of the auxiliary close outputs: one P2TR entry per party with a non-zero asset balance. lnd uses this shape to include the aux output weight in the coop close fee baseline, and validates the concrete outputs returned byAuxCloseOutputsagainst it before signing a proposal. The close fee only affects the values of the asset outputs, never their number or script sizes, which is the invariant that makes the shape fee-independent.The first commit bumps lnd to a master version that contains the new interface method.
Regression itest
coop_close_fee_baselineopens an asset channel and cooperatively closes it at the relay floor fee rate (1 sat/vByte), asserting that the close transaction confirms and carries the expected auxiliary output. At the relay floor there is no headroom: a fee baseline that omits the aux output weight produces a close transaction below the relay fee rate, which the mempool rejects, and the test times out waiting for the close.Run with
make itest-cc cccase=coop_close_fee_baseline.