itest: run lnd backend in remote-signing mode

[guggero]

Depends on btcsuite/btcwallet#1022 and then lightningnetwork/lnd#10119 which will hopefully make it into lnd v0.19.3-beta.

Created this itest to reproduce lightninglabs/lightning-terminal#1123.
Further investigation then lead to the creation of this bug report issue: lightningnetwork/lnd#10120

So this test will not succeed until lightningnetwork/lnd#10120 is fixed. But putting up the PR as a draft as we should aim to fix that issue and then have these tests run in the CI by default.

[coveralls]

Coverage Report for CI Build 26889171221

Coverage decreased (-0.03%) to 34.83%

Details

• Coverage decreased (-0.03%) from the base build.
• Patch coverage: 64 uncovered changes across 2 files (0 of 64 lines covered, 0.0%).
• 37 coverage regressions across 8 files.

Uncovered Changes

File	Changed	Covered	%
itest/test_harness.go	48	0	0.0%
itest/multisig.go	16	0	0.0%

Coverage Regressions

37 previously-covered lines in 8 files lost coverage.

File	Lines Losing Coverage	Coverage
address/mock.go	14	88.59%
tapdb/multiverse.go	6	54.43%
tapgarden/caretaker.go	6	68.5%
asset/mock.go	3	65.89%
tapgarden/planter.go	3	63.34%
asset/asset.go	2	46.74%
tappsbt/create.go	2	22.71%
commitment/tap.go	1	72.67%

---

Coverage Stats

Relevant Lines:	102270
Covered Lines:	35621
Line Coverage:	34.83%
Coverage Strength:	0.37 hits per line

---

💛 - Coveralls

[guggero]

With lnd v0.19.3-beta.rc1 out, this is now out of draft.

[jtobin]

LGTM 👍 👍

[jtobin]

I've rebased this, as it seems easy enough to resurrect and review otherwise. Unsure we actually want to run w/remote signing mode in CI, though.

[jtobin]

lightninglabs-deploy mute

[lightninglabs-deploy]

@GeorgeTsagk: review reminder
@guggero, remember to re-request review from reviewers when ready

[guggero]

!lightninglabs-deploy mute

[GeorgeTsagk]

Kept mint_assets and basic_send_unidirectional in the coverage: those give us the biggest coverage with the smallest set of test cases (anchor sign / ImportTapscript / script key spend / groupkey sign)

[jtobin]

LGTM, with only one substantial note: the CI workflow still uses the older style that we've since optimized. A few tweaks worth making:

diff --git a/.github/workflows/main.yaml b/.github/workflows/main.yaml
index 05bc726c..5cd5e16e 100644
--- a/.github/workflows/main.yaml
+++ b/.github/workflows/main.yaml
@@ -467,20 +467,30 @@ jobs:
   integration-test-lnd-remote-signer:
     name: run itests with lnd remote-signer
     runs-on: ubuntu-latest
+    needs: build-itest
     steps:
-      - name: cleanup space
-        run: rm -rf /opt/hostedtoolcache
-
       - name: git checkout
         uses: actions/checkout@v5
 
-      - name: Setup go ${{ env.GO_VERSION }}
-        uses: actions/setup-go@v5
+      - name: Download itest binaries
+        uses: actions/download-artifact@v8
         with:
-          go-version: '${{ env.GO_VERSION }}'
+          name: itest-binaries
+          path: itest
+
+      - name: Initialize environment
+        run: |
+          chmod +x itest/itest.test itest/btcd-itest itest/lnd-itest itest/tapd-itest itest/chantools/chantools
+          mkdir -p ~/.aperture
+
+      - name: CPU info
+        run: |
+          echo "nproc (available to process): $(nproc)"
+          echo "nproc --all (online): $(nproc --all)"
+          lscpu || true
 
       - name: run itest
-        run: make itest icase='(mint_assets|basic_send_unidirectional)' remotesigning=1
+        run: scripts/itest_part.sh 0 1 0 --verbose -lndremotesigner -test.run='TestTaprootAssetsDaemon/tranche.*/.*-of-.*/^(mint_assets|basic_send_unidirectional)$'
 
       - name: Zip log files on failure
         if: ${{ failure() }}
@@ -499,7 +509,7 @@ jobs:
         if: ${{ success() }}
         continue-on-error: true
         with:
-          file: itest/coverage.txt
+          files: itest/regtest/cover/coverage-tranche0.txt
           flag-name: 'itest-remotesigner'
           format: 'golang'
           parallel: true

This mostly just copies the stuff the other itests do, i.e.:

• ditches the old cleanup space step (no longer needed)
• removes the setup-go step (ditto)
• uses the itest binaries from the previous build job
• invokes scripts/itest_part.sh directly ('make itest' rebuilds the binaries, apparently)
• writes the coverage stuff to tranche0, which is apparently the right location

(One nit, too: the release note commit can probably be dropped.)