Bump ldk-node dependency to 47dad6d909af0fbb53e76d07740c04df5abdde3b#230
Draft
enigbe wants to merge 1 commit into
Draft
Bump ldk-node dependency to 47dad6d909af0fbb53e76d07740c04df5abdde3b#230enigbe wants to merge 1 commit into
47dad6d909af0fbb53e76d07740c04df5abdde3b#230enigbe wants to merge 1 commit into
Conversation
Update ldk-node to a newer revision and adapt ldk-server to the changed payment event surface. PaymentForwarded now preserves the full prev_htlcs and next_htlcs vectors in the gRPC model while keeping the legacy scalar channel/node fields populated from the first HTLC for compatibility. Remove the Bolt11Jit payment kind as a breaking API change. JIT BOLT 11 payments are now represented as regular Bolt11 payments with counterparty_skimmed_fee_msat set when applicable, and the former oneof tag/name are reserved in the proto. Regenerate protobuf bindings and drop the obsolete Bolt11Jit serde attribute. AI-Assisted-By: OpenAI Codex
|
👋 Hi! I see this is a draft PR. |
Collaborator
|
Can you bump to |
Comment on lines
+33
to
+34
| reserved 3; | ||
| reserved "bolt11_jit"; |
Collaborator
There was a problem hiding this comment.
we aren't worrying about backwards compat yet so you can remove this
| // See more: https://docs.rs/ldk-node/latest/ldk_node/enum.Event.html#variant.PaymentForwarded | ||
| message ForwardedPayment{ | ||
| // The channel id of the incoming channel between the previous node and us. | ||
| // Deprecated: use `prev_htlcs` instead. This is populated from `prev_htlcs[0]` |
Collaborator
There was a problem hiding this comment.
if these fields are deprecated it's probably best if we drop them all
| // | ||
| // Will only be `Some` once we received the payment. | ||
| optional uint64 counterparty_skimmed_fee_msat = 5; | ||
| // Replaces the former `PaymentKind.bolt11_jit.counterparty_skimmed_fee_msat` |
Collaborator
There was a problem hiding this comment.
we dont need to mention the old format, we haven't released yet so no one knows the former one
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Bumps the
ldk-nodedependency to revision 47dad6d, which, among other changes, contains the prerequisite for exposingNodeFeaturestoldk-servercallers via the nodestatusendpoint. We need this for callers interested in querying the features supported by the node.Notable upstream changes adapted here
Bolt11Jitmerged into Bolt11: ldk-node folded the JIT payment variant intoBolt11, adding acounterparty_skimmed_fee_msatfield. TheBolt11Jitproto message, its serde attribute inbuild.rs, and the corresponding proto_adapter arm are all removed. The original proto tag numbers for Bolt12Offer (4), Bolt12Refund (5), and Spontaneous (6) are preserved — tag 3 is reserved to avoid wire-compatibility issues with previously-serializedBolt11Jitdata.PaymentForwardedevent restructured aroundHTLCLocator: The six flat channel/node/user-channel-id fields are replaced byprev_htlcsandnext_htlcs(Vec<HTLCLocator>), supporting multi-HTLC forwards. The legacy scalar fields are retained in the proto as deprecated, populated from the first element of each vec for backward compatibility (not sure if this is the correct way to handle this).