Update rust crates dependencies#1332
Open
BraveChicken1 wants to merge 1 commit intolief-project:mainfrom
Open
Conversation
Member
|
Thank you. Two questions:
|
Contributor
Author
|
No, I did not use AI to generate any of this. I read through the changelogs and crates.io pages myself and then upgraded the dependencies to the most recent, still compatible version. I know the diff is very big, but this is mainly because the lock files were regenerated by cargo. I did test if lief still builds and runs on Windows, and this does indeed still work. |
Member
|
Ok thank you. I'm not against bumping the MSRV but I'll need to assess the impact on the build pipeline |
Contributor
Author
|
Yes, I understand that bumping the MSRV has some impact on the library, but I think bumping it now is a good moment to future proof LIEF. Let me know if there is anything I can help with. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the dependencies of the several rust crates.
It bumps the versions of dependencies, removes unused dependencies and moves the tempfile dependency to the dev-dependencies, since it's only used by the tests. It also changes the
elf_tests.rstest, by ensuring it does not use the reservedgenkeyword anymore.As a result of this the MSRV is bumped to 1.85.0.
By bumping the dependencies, we can benefit of the stability improvements of these dependencies, and more important several vulnerability fixes to these dependencies.
Dependents of LIEF benefit of this, because the overal security and stability of the bindings improve and their dependency tree does not need to contain older package versions anymore. This then also results in improved security and stability of the dependents.
Please note that miette, zip and cxx were not updated to the latest versions, because of compatibility issues with autocxx (miette and cxx) and because I don't want to bump the MSRV too far (zip 8.5.1 requires MSRV 1.88.0, while 1.85.0 is the current standard for big Rust projects).
To support upgrading miette and cxx, we would need to bump the dependencies of autocxx too. The autocxx project seems to be a bit inactive at the moment, but I will try to get the changes into the latest version of autocxx. This will then also contain the bump of the
aquamarinedependency, which you have changed on your own fork of autocxx. I will open a follow up PR once autocxx is upgraded.LIEF still builds and works after these changes, I tested this on several different types of machines. I also read through the changelogs of the different dependencies to ensure there were no breaking changes for LIEF.
Some small final notices: