Add NEON support for ARMv7#792
Conversation
| - name: Clippy with all features | ||
| if: ${{ matrix.features == 'all' }} | ||
| run: cargo clippy --release --all-targets --all-features --tests --all -- -D warnings | ||
| run: cargo clippy --release --all-targets --all-features --all -- -D warnings |
There was a problem hiding this comment.
This is removed because --all-targets include tests.
veluca93
left a comment
veluca93
left a comment
There was a problem hiding this comment.
Some high-level thoughts: AFAIU NEON on ARMv7 is currently nightly because there are still some soundness issues with the backend. Thus, I'd prefer not to add the support unless we have some clear and important use cases.
If we do, then I imagine it should be fine if we rename the "nightly" feature to something a bit more scary ("enable-potentially-broken-targets"?) and leave it off by default. As a side note, why do we need the feature flag on jxl_transforms?
I'm aware of that, but not sure how it would affect us. Does jxl-rs rely on subnormals?
It's necessary because |
I dislike soundness issues as a general rule :-) Also, doesn't the |
That's why the feature flag is added to the |
My bad, I missed that... |
2 participants
compare_incremental_tirr_photo,compare_pipelines_progressiveandcompare_pipelines_tirr_photoare skipped in CI due to OOM.Local benchmark shows 2.7x speedup on
bike.jxl(2.66 to 7.21 MP/s) and 2.2x speedup ongreen_queen_vardct_e3.jxl(3.79 to 8.47 MP/s).