perf: add HybridUint::read fast path for msb_in_token == 0#737
Closed
hjanuschka wants to merge 1 commit into
Closed
perf: add HybridUint::read fast path for msb_in_token == 0#737hjanuschka wants to merge 1 commit into
hjanuschka wants to merge 1 commit into
Conversation
Benchmark @ 3ba6a16Comparing: 7cf3a662 (Base) vs 38065842 (PR)
|
veluca93
reviewed
Mar 25, 2026
14427b7 to
e5dbeb3
Compare
e5dbeb3 to
3ba6a16
Compare
Member
|
I'd say that since perf is neutral the additional code complexity is not worth it, so closing it for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Carved out from the ongoing perf/autoresearch stream after PR #705 split work.
Change:
HybridUint::readfor the commonmsb_in_token == 0case.Why: