Skip to content

Incremental link msvc release builds, comments, rem dead code. #811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
evoskuil merged 3 commits into from
Jun 5, 2026
Merged

Incremental link msvc release builds, comments, rem dead code. #811

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ac4559e
Incremental link msvc release builds.
evoskuil Jun 5, 2026
da262df
Comment style.
evoskuil Jun 5, 2026
904ef2c
Remove dead code.
evoskuil Jun 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion builds/msvc/properties/Release.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
<PropertyGroup>
<_PropertySheetDisplayName>Release Settings</_PropertySheetDisplayName>
<DebugOrRelease>Release</DebugOrRelease>
<LinkIncremental>false</LinkIncremental>
<!--<LinkIncremental>false</LinkIncremental>-->
</PropertyGroup>

<!-- DebugInformationFormat and GenerateDebugInformation were formerly disabled. -->
Expand Down
4 changes: 2 additions & 2 deletions include/bitcoin/database/query.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -845,14 +845,14 @@ class query
/// merkle
/// -----------------------------------------------------------------------

// merkle related utilities
/// merkle related utilities
static hash_digest partial_subroot(hashes&& tree, size_t span) NOEXCEPT;
static void merge_merkle(hashes& path, hashes&& leaves, size_t first,
size_t lift) NOEXCEPT;
static positions merkle_branch(size_t leaf, size_t leaves,
bool compress=false) NOEXCEPT;

// merkle related configuration
/// merkle related configuration
size_t interval_depth() const NOEXCEPT;
size_t initialize_span() const NOEXCEPT;

Expand Down
4 changes: 0 additions & 4 deletions include/bitcoin/database/tables/caches/ecdsa.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,10 +72,6 @@ struct ecdsa
};
};

////static_assert(offsetof(system::ecdsa::triple, digest) == 0);
////static_assert(offsetof(system::ecdsa::triple, point) == 32);
////static_assert(offsetof(system::ecdsa::triple, signature) == 65);
////static_assert(offsetof(system::ecdsa::triple, identifier) == 129);
static_assert(sizeof(system::ecdsa::triple) == schema::ecdsa::minrow);

} // namespace table
Expand Down
6 changes: 0 additions & 6 deletions include/bitcoin/database/tables/caches/multisig.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,12 +80,6 @@ struct multisig
};
};

////static_assert(offsetof(system::multisig::triple, digest) == 0);
////static_assert(offsetof(system::multisig::triple, point) == 32);
////static_assert(offsetof(system::multisig::triple, signature) == 65);
////static_assert(offsetof(system::multisig::triple, pair) == 129);
////static_assert(offsetof(system::multisig::triple, set) == 130);
////static_assert(offsetof(system::multisig::triple, identifier) == 132);
static_assert(sizeof(system::multisig::triple) == schema::multisig::minrow);

} // namespace table
Expand Down
4 changes: 0 additions & 4 deletions include/bitcoin/database/tables/caches/schnorr.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,10 +72,6 @@ struct schnorr
};
};

////static_assert(offsetof(system::schnorr::triple, digest) == 0);
////static_assert(offsetof(system::schnorr::triple, point) == 32);
////static_assert(offsetof(system::schnorr::triple, signature) == 64);
////static_assert(offsetof(system::schnorr::triple, identifier) == 128);
static_assert(sizeof(system::schnorr::triple) == schema::schnorr::minrow);

} // namespace table
Expand Down
Loading