Tracing utils moved into reactor-c#259
Merged
Merged
Conversation
lhstrh
reviewed
Aug 18, 2023
lhstrh
reviewed
Aug 18, 2023
lhstrh
reviewed
Aug 18, 2023
lhstrh
reviewed
Aug 18, 2023
lhstrh
reviewed
Aug 18, 2023
lhstrh
reviewed
Aug 18, 2023
lhstrh
reviewed
Aug 18, 2023
lhstrh
reviewed
Aug 18, 2023
lhstrh
requested changes
Aug 18, 2023
Member
lhstrh
left a comment
lhstrh
left a comment
There was a problem hiding this comment.
Looks OK modulo comments. Thanks for doing this!
Co-authored-by: Marten Lohstroh <marten@berkeley.edu>
Collaborator
Author
|
@lhstrh do you know whats going on with the test failures? Seems related to a recent merge in |
Collaborator
Author
|
I restored a branch in the main repo and now it works. But there are some non-determinsitic federated test failures here... |
lhstrh
approved these changes
Aug 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moving tracing utilities from
lingua-francatoreactor-c. Also install them to/usr/local/bin.