Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 24 additions & 24 deletions kolibri/plugins/perseus_viewer/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,30 +7,30 @@
"private": true,
"version": "0.0.1",
"dependencies": {
"@khanacademy/kas": "^0.3.8",
"@khanacademy/math-input": "19.2.1",
"@khanacademy/mathjax-renderer": "^2.0.0",
"@khanacademy/perseus-core": "^1.5.2",
"@khanacademy/perseus": "22.7.0",
"@khanacademy/wonder-blocks-banner": "3.0.42",
"@khanacademy/wonder-blocks-button": "6.3.1",
"@khanacademy/wonder-blocks-clickable": "4.2.1",
"@khanacademy/wonder-blocks-core": "6.4.0",
"@khanacademy/wonder-blocks-data": "13.0.7",
"@khanacademy/wonder-blocks-dropdown": "5.3.0",
"@khanacademy/wonder-blocks-form": "4.5.1",
"@khanacademy/wonder-blocks-icon": "4.1.0",
"@khanacademy/wonder-blocks-layout": "2.0.32",
"@khanacademy/wonder-blocks-link": "6.1.1",
"@khanacademy/wonder-blocks-pill": "2.2.1",
"@khanacademy/wonder-blocks-popover": "3.2.2",
"@khanacademy/wonder-blocks-progress-spinner": "2.1.1",
"@khanacademy/wonder-blocks-switch": "1.1.16",
"@khanacademy/wonder-blocks-tokens": "1.3.0",
"@khanacademy/wonder-blocks-tooltip": "2.3.1",
"@khanacademy/wonder-blocks-typography": "2.1.11",
"@khanacademy/wonder-blocks-timing": "^5.0.0",
"@khanacademy/wonder-stuff-core": "^1.5.2",
"@khanacademy/kas": "^2.2.3",
"@khanacademy/math-input": "26.4.30",
"@khanacademy/mathjax-renderer": "^3.0.2",
"@khanacademy/perseus-core": "^27.1.0",
"@khanacademy/perseus": "77.9.0",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blocking: @khanacademy/perseus jumps 55 major versions (22.7.0 → 77.9.0). Perseus and its wonder-blocks dependencies now declare react: ^18.2.0 as a peer dependency (confirmed in the updated lockfile — multiple entries change from react: 16.14.0 to react: ^18.2.0 / react: 18.2.0). The perseus_viewer pins "react": "16.14.0", so pnpm resolves all packages against React 16, but these packages were developed and tested against React 18 and may use React 18-specific APIs (createRoot, concurrent features, etc.).

The Frontend tests and Browser smoke test (currently QUEUED) are the definitive signal — if they pass, the packages are compatible with React 16 in practice. But this peer dep mismatch should be explicitly verified before merge rather than assumed safe.

"@khanacademy/wonder-blocks-banner": "5.1.1",
"@khanacademy/wonder-blocks-button": "11.6.1",
"@khanacademy/wonder-blocks-clickable": "8.2.0",
"@khanacademy/wonder-blocks-core": "12.4.4",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blocking: wonder-blocks-core introduced React 18 as a hard peer dependency at v8.0.0 ("Upgrade to React 18" breaking change in its changelog). This PR brings it to v12.4.4, meaning all wonder-blocks packages transitively require React 18. This is the root cause of the peer dep mismatch noted on @khanacademy/perseus above.

"@khanacademy/wonder-blocks-data": "15.0.2",
"@khanacademy/wonder-blocks-dropdown": "10.9.1",
"@khanacademy/wonder-blocks-form": "7.6.1",
"@khanacademy/wonder-blocks-icon": "5.3.15",
"@khanacademy/wonder-blocks-layout": "3.1.52",
"@khanacademy/wonder-blocks-link": "10.3.0",
"@khanacademy/wonder-blocks-pill": "3.1.64",
"@khanacademy/wonder-blocks-popover": "6.3.1",
"@khanacademy/wonder-blocks-progress-spinner": "3.1.52",
"@khanacademy/wonder-blocks-switch": "3.4.1",
"@khanacademy/wonder-blocks-tokens": "16.5.0",
"@khanacademy/wonder-blocks-tooltip": "4.1.76",
"@khanacademy/wonder-blocks-typography": "4.3.5",
"@khanacademy/wonder-blocks-timing": "^7.1.0",
"@khanacademy/wonder-stuff-core": "^3.0.0",
"@phosphor-icons/core": "^2.1.1",
"@popperjs/core": "^2.10.1",
"aphrodite": "https://github.com/learningequality/aphrodite/",
Expand Down
Loading
Loading