feat: tag linter warnings for recordLints#13844
Open
wkrozowski wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
!bench |
|
Benchmark results for 6ce247a against 55cf1d7 are in. No significant results found. @wkrozowski
Small changes (3✅, 2🟥)
|
|
Mathlib CI status (docs):
|
Collaborator
|
Reference manual CI status:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes
Lean.Linter.logLintattach an internal tag to everylinter warning so that
Lean.Linter.recordLintscan reliably distinguishlinter-produced messages from other tagged messages (named errors,
unknown-identifier messages,
hasSorrymarkers, etc.). Previously,recordLintscaptured every message whose top-level kind was non-anonymous,which over-recorded non-linter diagnostics into the persistent lint log.
The change preserves the existing
MessageData.kindof linter warnings (itstill returns the linter option name) by nesting the sentinel tag inside the
kind tag. A new helper
MessageData.isLinterMessageis exposed alongside theexisting
isDeprecationWarning/isUnusedVariableWarningpredicates.