fix: preserve cases params in grind? suggestions#13835
Open
raphael-solace wants to merge 1 commit into
Open
Conversation
Author
|
I do not have permission to add labels on this repo. This should get \ (or another maintainer-preferred changelog label) to satisfy the PR body check. |
Author
|
Correction: the needed label is changelog-tactics (or another maintainer-preferred changelog label). |
github-actions
Bot
added
the
toolchain-available
Collaborator
|
Reference manual CI status:
|
github-actions
Bot
added
the
mathlib4-nightly-available
mathlib-lean-pr-testing
Bot
added
the
builds-mathlib
|
Mathlib CI status (docs):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR preserves explicit
casesparameters ingrind?suggestions.grind?already preserves non-ident term parameters when reconstructinggrind onlysuggestions because they are not tracked through E-matching. Explicitcasesparameters are another non-E-matching input: they update the case-split configuration.The added regression tests check that
grind?suggestions contain the requiredcases Boolandcases Optionparameters.Fixes #13828.
Tests:
git diff --checklocally. I did not run the Lean test suite locally because this workspace is a shallow sparse checkout without a local Lean toolchain.