chore: turn defLemma linter into Lean.Linter and rename it to defProp#13803
Open
wkrozowski wants to merge 5 commits into
Open
chore: turn defLemma linter into Lean.Linter and rename it to defProp#13803wkrozowski wants to merge 5 commits into
defLemma linter into Lean.Linter and rename it to defProp#13803wkrozowski wants to merge 5 commits into
Conversation
github-actions
Bot
added
the
toolchain-available
Collaborator
|
Reference manual CI status:
|
github-actions
Bot
added
the
mathlib4-nightly-available
mathlib-lean-pr-testing
Bot
added
the
builds-mathlib
|
Mathlib CI status (docs):
|
mathlib-nightly-testing Bot
pushed a commit
to leanprover-community/batteries
that referenced
this pull request
May 20, 2026
mathlib-nightly-testing Bot
pushed a commit
to leanprover-community/mathlib4-nightly-testing
that referenced
this pull request
May 20, 2026
mathlib-nightly-testing Bot
pushed a commit
to leanprover-community/batteries
that referenced
this pull request
May 20, 2026
mathlib-nightly-testing Bot
pushed a commit
to leanprover-community/mathlib4-nightly-testing
that referenced
this pull request
May 20, 2026
wkrozowski
changed the title
defLemma linter into Lean.Linter (WIP)defLemma linter into Lean.Linter and rename it to defProp (WIP)
wkrozowski
changed the title
defLemma linter into Lean.Linter and rename it to defProp (WIP)defLemma linter to defProp
wkrozowski
changed the title
defLemma linter to defPropdefLemma linter into Lean.Linter and rename it to defProp.
wkrozowski
changed the title
defLemma linter into Lean.Linter and rename it to defProp.defLemma linter into Lean.Linter and rename it to defProp
mathlib-nightly-testing Bot
pushed a commit
to leanprover-community/batteries
that referenced
this pull request
May 25, 2026
mathlib-nightly-testing Bot
pushed a commit
to leanprover-community/mathlib4-nightly-testing
that referenced
this pull request
May 25, 2026
mathlib-nightly-testing Bot
pushed a commit
to leanprover-community/batteries
that referenced
this pull request
May 25, 2026
mathlib-nightly-testing Bot
pushed a commit
to leanprover-community/mathlib4-nightly-testing
that referenced
this pull request
May 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR renames the
defLemmalinter todefPropand clarifiesits warning message.
The linter is also moved out of the
EnvLinterframework into its own fileLean.Linter.DefProp, since it now processes elaboration info trees per command.The helper
getDeclsByBodyis exposed inLean.Linter.Utilfor reuse.