Add Japanese localization of Academy at /academy/japan/ #3018
+1,278
−44
Claude / Claude Code Review
completed
May 29, 2026 in 7m 55s
Code review found 2 potential issues
Found 5 candidates, confirmed 2. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 2 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | content/academy/japan/evaluate.mdx:197-198 |
ManualGuideList does not accept locale prop |
| 🟡 Nit | components/academy/ErrorAnalysisProcessDiagram.tsx:105 |
Use steps.length, not STEPS.length, for connector check |
Annotations
Check warning on line 198 in content/academy/japan/evaluate.mdx
claude / Claude Code Review
ManualGuideList does not accept locale prop
`<ManualGuideList locale="ja" title="その他のガイド" guides={...}/>` passes a `locale="ja"` prop, but `ManualGuideList` only accepts `{ title?, guides }` — React silently drops the unknown prop. It's currently harmless because `title` is explicitly overridden, but it's misleading dead code that pattern-matches the other locale-aware Academy components in this PR (`LoopDiagram`, `ManualGuideCallout`, `EvaluationEvolutionDiagram`, etc.). Either drop the `locale` prop from the call site or extend `ManualG
Check warning on line 105 in components/academy/ErrorAnalysisProcessDiagram.tsx
claude / Claude Code Review
Use steps.length, not STEPS.length, for connector check
The .map at line 105 iterates the locale-aware `steps` array, but the connector guard at line 120 still references `STEPS.length` (the English-only constant). Both `STEPS` and `STEPS_JA` happen to have 5 entries today, so there is no user-visible defect, but a future contributor adding or removing a step from one array only would render an orphan connector or miss one. One-line fix: `STEPS.length` → `steps.length`.
Loading