chore: improvements to clickhouse and data masking - #2985
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
@claude review |
Steffen911
approved these changes
May 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Greptile Summary
This PR improves two self-hosting documentation pages: it adds a "Direct ClickHouse Access for Custom Tools" section to
clickhouse.mdx, and refinesdata-masking.mdxwith a new blob-storage timing warning, a corrected error-handling table (fail-open is the actual default, not fail-closed), and fixed container references (Worker vs Web) throughout the troubleshooting section.clickhouse.mdx: Adds guidance for users querying ClickHouse directly, clarifies theCLICKHOUSE_READ_ONLY_URLscope, and aligns the Cloud/BYOC recommendation paragraph with the updated description.data-masking.mdx: Fixes the inverted error-handling table (default is fail-open/false, not fail-closed), corrects "Langfuse Web container" → "Langfuse Worker container" in troubleshooting, adds a warning that events are written to blob storage before the masking callback runs, and clarifies that only invalid JSON (not structural schema mismatch) triggers error-handling behavior.Confidence Score: 4/5
Safe to merge for the ClickHouse page; the data-masking page would benefit from one additional sentence clarifying blob-storage retention before operators rely on it for compliance decisions.
Both files are documentation-only changes. The ClickHouse additions are clear and accurate. The data-masking corrections (table column order, container name fixes) are genuine improvements. The one gap is that the new blob-storage warning in data-masking.mdx omits whether unmasked blob-storage data is ever cleaned up — this matters for operators reading this page to evaluate GDPR/HIPAA compliance posture, and a misleading silence there could lead to incorrect architectural decisions.
content/self-hosting/security/data-masking.mdx — the blob-storage data retention clause in the new warning callout (lines 55–61).
Security Review
data-masking.mdxnow discloses that events are written to blob storage before the masking callback runs, meaning blob storage retains unmasked PII. The documentation does not clarify whether this copy is ever replaced or deleted. Operators deploying server-side masking for GDPR/HIPAA/PCI DSS compliance may incorrectly assume their entire storage layer is protected.Sequence Diagram
sequenceDiagram participant SDK as Langfuse SDK participant Web as Langfuse Web participant Bucket as Blob Storage (S3) participant Worker as Langfuse Worker participant Callback as Masking Callback participant CH as ClickHouse SDK->>Web: Send trace event (may contain PII) Web->>Bucket: Store UNMASKED event Note over Bucket: ⚠️ Unmasked data persists here Web->>Worker: Forward S3 reference (via Redis) Worker->>Bucket: Fetch unmasked event Worker->>Callback: POST OpenTelemetry object alt Callback succeeds Callback->>Worker: Return masked object Worker->>CH: Write MASKED data else Fail open (default) Worker->>CH: Write UNMASKED data, log warning else "Fail closed (FAIL_CLOSED=true)" Worker->>Worker: Drop event, log warning endPrompt To Fix All With AI
Reviews (1): Last reviewed commit: "improvements to clickhouse and data mask..." | Re-trigger Greptile