fix(anthropic): preserve empty thinking field in signature_delta streaming#38765
Open
Yuchen Fan (Functionhx) wants to merge 3 commits into
Open
fix(anthropic): preserve empty thinking field in signature_delta streaming#38765Yuchen Fan (Functionhx) wants to merge 3 commits into
Yuchen Fan (Functionhx) wants to merge 3 commits into
Conversation
Yuchen Fan (Functionhx)
requested review from
ccurme (ccurme) and
Mason Daugherty (mdrxy)
as code owners
July 10, 2026 02:25
github-actions
Bot
added
anthropic
Empty adaptive-thinking blocks with only a signature_delta were
missing the thinking key in the reconstructed chunk. Replay to the
API failed with 400 thinking.thinking: Field required.
Added setdefault("thinking", "") so the field is always present.
Signed-off-by: Yuchen Fan <functionhx@gmail.com>
Yuchen Fan (Functionhx)
force-pushed
the
fix/anthropic-thinking-field
branch
from
July 10, 2026 02:25
9a27ab1 to
1ca5062
Compare
Signed-off-by: Yuchen Fan <functionhx@gmail.com>
|
ccurme (@ccurme) I previously raised an issue about this PR. This solution looks reasonable to me. After reviewing the overall implementation, do you think there might be a more fundamental way to solve this? I'd appreciate your thoughts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #38639
Streamed signature_delta chunks from empty adaptive-thinking blocks were missing the required thinking key, causing 400 errors on replay. Added setdefault.