feat: add distributed cleanup old versions#5160
Open
LuciferYang wants to merge 3 commits into
Open
Conversation
Follow-up review hardening on top of the distributed cleanup feature. - Guard retain_versions <= 0 in both cleanup_old_versions and cleanup_database_old_versions. retain_versions=0 otherwise triggers a Rust PanicException in Lance core (a BaseException) that escapes the worker's `except Exception`, aborting the whole batch with a generic error and breaking the documented per-table aggregation contract. - Expand docstrings to the compaction.py bar: full Args/Returns/Raises, the deliberate parallel-aggregate vs serial-fail-fast contrast, num_workers semantics, the non-atomic/destructive Warning, the 7-day delete_unverified guard, and the conditional two-week older_than default. - Extract the page-size literal into the named _LIST_TABLES_PAGE_SIZE, annotate _handle_cleanup_table's return type, and tighten _cleanup_stats_to_dict to dict[str, int]. - Document the parallel/aggregate behavior, non-atomic warning, and stat field names in docs/src/compaction.md. - Strengthen tests: uri-vs-namespace validation, retain_versions rejection, safe-default pinning (incl. num_workers=4), 3-page pagination, exact partial-failure message, failure-path pool close/join and __cause__ chaining, and a CleanupStats field drift guard.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cleanup_old_versionsfor single-table old-version cleanup with URI or namespace table resolutioncleanup_database_old_versionsto run old-version cleanup across namespace tables with a Ray PoolTesting
python -m ruff check .python -m ruff format --check lance_ray/cleanup.py tests/test_cleanup.py lance_ray/__init__.pypython -m pytest tests/test_cleanup.py tests/test_distributed_compaction.py::TestCompactDatabase -qCloses #98