Skip to content

fix: read context records through MemWAL scanner#51

Merged
beinan merged 1 commit into
lance-format:mainfrom
beinan:fix/memwal-read-path-tests
Jun 8, 2026
Merged

fix: read context records through MemWAL scanner#51
beinan merged 1 commit into
lance-format:mainfrom
beinan:fix/memwal-read-path-tests

Conversation

@beinan

@beinan beinan commented Jun 8, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Route ContextStore::list through Lance's MemWAL LSM scanner so flushed WAL generations are visible to reads.
  • Compute semantic search over LSM-visible records and restore the MemWAL key-path assertions.
  • Keep list pagination semantics explicit after collection instead of relying on an offset-only scanner limit.

Testing

  • cargo fmt --all --check
  • cargo clippy --workspace --all-targets -- -D warnings
  • cargo test --workspace
  • uv run --extra tests pytest python/tests/ -v
  • uv run --extra dev ruff format --check python/
  • uv run --extra dev ruff check python/
  • uv run --extra dev pyright

Notes

  • The repo helper script .codex/skills/ci-pr-helper/scripts/run_ci_checks.sh currently references rust/lance-context/Cargo.toml, which does not exist in this workspace, so I ran the current CI-equivalent commands above.
  • uv run --extra tests pytest without the CI path filter still has existing failures in tests/test_compaction.py and tests/test_persistence.py; those tests directly inspect base Lance fragments/rows or moto S3 behavior outside the MemWAL-aware read path.

@beinan beinan merged commit e62de53 into lance-format:main Jun 8, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant