Skip to content

feat: setuptools version pin #208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tsingletonacic wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

feat: setuptools version pin #208

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions defaults/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,7 @@ netbox_napalm_enabled: false
netbox_napalm_packages:
- napalm

netbox_setuptools_version: ""
netbox_pip_extra_args: [] # Additional pip arguments (e.g., ['--no-cache-dir', '-i', 'https://pypi.example.com/simple'])
netbox_pip_packages: []
netbox_pip_constraints:
Expand Down
4 changes: 2 additions & 2 deletions tasks/deploy_netbox.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,8 @@
ansible.builtin.pip:
name:
- pip
- setuptools
state: latest
- "setuptools{{ netbox_setuptools_version|default('') }}"
Copy link
Copy Markdown
Owner

@lae lae Apr 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the default filter here is redundant, I believe?

Copy link
Copy Markdown
Author

@tsingletonacic tsingletonacic Apr 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is a second safety just in case, but it can be removed indeed, I will let you decide.

Thanks

Copy link
Copy Markdown
Owner

@lae lae Apr 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, as far as I understand it is dead code and should be removed.

state: present
virtualenv: "{{ netbox_virtualenv_path }}"
virtualenv_command: "{{ netbox_python_binary }} -m venv"
become: true
Expand Down