fix(BA-6259): drop stale top-level ui_type from install runtime variant preset fixture#11894
Merged
Conversation
…nt preset fixture Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes installation fixture loading for runtime variant presets by removing a stale top-level ui_type field that no longer exists as a database column (it was folded into ui_option), preventing mgr fixture populate from failing with sqlalchemy.exc.CompileError: Unconsumed column names: ui_type.
Changes:
- Remove stale top-level
ui_typekeys fromexample-runtime-variant-presets.jsonentries while keepingui_typenested underui_option. - Add a towncrier news fragment documenting the fix.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/ai/backend/install/fixtures/example-runtime-variant-presets.json |
Drops top-level ui_type fields to match the current RuntimeVariantPresetRow schema and allow fixture population to succeed. |
changes/11894.fix.md |
Adds a changelog fragment describing the fixture populate CompileError fix. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
HyeockJinKim
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RuntimeVariantPresetRowfolded the separateui_typecolumn into theui_optionJSONB, but the install seed fixture still carried a top-level"ui_type"key on each entry.mgr fixture populateto fail withsqlalchemy.exc.CompileError: Unconsumed column names: ui_type.ui_typelines;ui_typeremains correctly nested insideui_option.Test plan
./backend.ai mgr fixture populate src/ai/backend/install/fixtures/example-runtime-variant-presets.json→ Done, no CompileErrorui_optionJSONB containsui_type(e.g.dtype→"ui_type": "select")Resolves BA-6259