Skip to content

fix(BA-6259): drop stale top-level ui_type from install runtime variant preset fixture#11894

Merged
HyeockJinKim merged 2 commits into
mainfrom
fix/BA-6259
Jun 2, 2026
Merged

fix(BA-6259): drop stale top-level ui_type from install runtime variant preset fixture#11894
HyeockJinKim merged 2 commits into
mainfrom
fix/BA-6259

Conversation

@seedspirit
Copy link
Copy Markdown
Contributor

Summary

  • RuntimeVariantPresetRow folded the separate ui_type column into the ui_option JSONB, but the install seed fixture still carried a top-level "ui_type" key on each entry.
  • This caused mgr fixture populate to fail with sqlalchemy.exc.CompileError: Unconsumed column names: ui_type.
  • Removed the 29 stale top-level ui_type lines; ui_type remains correctly nested inside ui_option.

Test plan

  • ./backend.ai mgr fixture populate src/ai/backend/install/fixtures/example-runtime-variant-presets.json → Done, no CompileError
  • Delete all rows → confirm 0 → populate → 56 rows recreated (vllm 29 + sglang 27)
  • Verified ui_option JSONB contains ui_type (e.g. dtype"ui_type": "select")

Resolves BA-6259

…nt preset fixture

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
@github-actions github-actions Bot added the size:S 10~30 LoC label Jun 2, 2026
@github-actions github-actions Bot added size:M 30~100 LoC and removed size:S 10~30 LoC labels Jun 2, 2026
@seedspirit seedspirit added this to the 26.4 milestone Jun 2, 2026
@seedspirit seedspirit marked this pull request as ready for review June 2, 2026 01:55
@seedspirit seedspirit requested a review from a team as a code owner June 2, 2026 01:55
@seedspirit seedspirit requested a review from nowgnuesLee June 2, 2026 01:56
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes installation fixture loading for runtime variant presets by removing a stale top-level ui_type field that no longer exists as a database column (it was folded into ui_option), preventing mgr fixture populate from failing with sqlalchemy.exc.CompileError: Unconsumed column names: ui_type.

Changes:

  • Remove stale top-level ui_type keys from example-runtime-variant-presets.json entries while keeping ui_type nested under ui_option.
  • Add a towncrier news fragment documenting the fix.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/ai/backend/install/fixtures/example-runtime-variant-presets.json Drops top-level ui_type fields to match the current RuntimeVariantPresetRow schema and allow fixture population to succeed.
changes/11894.fix.md Adds a changelog fragment describing the fixture populate CompileError fix.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@HyeockJinKim HyeockJinKim merged commit 41a7a9e into main Jun 2, 2026
34 checks passed
@HyeockJinKim HyeockJinKim deleted the fix/BA-6259 branch June 2, 2026 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M 30~100 LoC

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants