Fp fix#70
Merged
dyumanaditya merged 14 commits intomainfrom Aug 26, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements a fixed point version of the PyReason reasoner and updates the existing codebase to support switching between the original and fixed point versions. The changes focus on adding support for fp_version configuration and ensuring proper test setup isolation.
Key changes:
- Add
fp_versionsetting to enable switching between reasoning implementations - Add
pr.reset_settings()calls to test setup for proper isolation - Create comprehensive test suite for the fixed point version functionality
Reviewed Changes
Copilot reviewed 18 out of 22 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
pyreason/pyreason.py |
Adds fp_version property and setter to Settings class, updates Program instantiation |
pyreason/scripts/program/program.py |
Adds fp_version parameter and conditional InterpretationFP instantiation |
tests/test_classifier.py |
Updates parameter name from model_name to identifier |
tests/test_hello_world.py |
Removes trailing whitespace |
| Multiple test files | Adds pr.reset_settings() calls for proper test isolation |
tests/fp_tests/ directory |
New comprehensive test suite for fixed point version functionality |
Comments suppressed due to low confidence (1)
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.