Skip to content

Define all floats in interval methods to be float64 to match constructor#118

Merged
ColtonPayne merged 2 commits intomainfrom
fix-bug-001-007
Feb 10, 2026
Merged

Define all floats in interval methods to be float64 to match constructor#118
ColtonPayne merged 2 commits intomainfrom
fix-bug-001-007

Conversation

@ColtonPayne
Copy link
Copy Markdown
Collaborator

@ColtonPayne ColtonPayne commented Feb 4, 2026

Summary

Fixes a type inconsistency where intersection methods used np.float32 for default values when intervals are disjoint, while the Interval struct fields are defined as float64. Changed all default float values to np.float64 to match the constructor and avoid type coercion issues.

Changes:

  • interval.py: Updated disjoint-interval defaults from np.float32 to np.float64
  • interval_type.py: Same fix in the overloaded intersection used by JIT-compiled code

Issues

Closes #87
Closes #88

@ColtonPayne ColtonPayne added the Ready for Review Awaiting PR Review label Feb 4, 2026
@kmukherji
Copy link
Copy Markdown
Member

Approved. Says merging is blocked.

@kmukherji kmukherji added Review complete and removed Ready for Review Awaiting PR Review labels Feb 10, 2026
@ColtonPayne ColtonPayne merged commit 377940c into main Feb 10, 2026
3 checks passed
@ColtonPayne ColtonPayne deleted the fix-bug-001-007 branch February 15, 2026 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BUG-007: Duplicate Type Inconsistency in Overloaded Intersection BUG-001: Type Inconsistency in Intersection Default Values

2 participants