Fix BUG-138: Correct threshold checking by filtering qualified groundings#101
Merged
ColtonPayne merged 10 commits intomainfrom Jan 30, 2026
Merged
Fix BUG-138: Correct threshold checking by filtering qualified groundings#101ColtonPayne merged 10 commits intomainfrom
ColtonPayne merged 10 commits intomainfrom
Conversation
…ings Fixed critical bug where check_all_clause_satisfaction was passing the same grounding twice instead of filtering by clause bounds. Problem: - check_node/edge_grounding_threshold_satisfaction received unfiltered groundings for both total and qualified parameters - This caused incorrect threshold calculations for both 'total' and 'available' quantifier types - Example: 5/5 = 100% instead of correct 2/4 = 50% Solution: - Extract clause_bnd from clause[3] - Call get_qualified_node/edge_groundings to filter by clause bounds - Pass filtered groundings as qualified_groundings parameter Changes: - interpretation.py: Added filtering in check_all_clause_satisfaction - interpretation_fp.py: Added same fix for consistency - test_ground_rule_helpers.py: Added comprehensive tests demonstrating the bug and validating the fix for both 'available' and 'total' quantifier types Tests: - test_check_all_clause_satisfaction_available_threshold_bug138 - test_check_all_clause_satisfaction_total_threshold_bug138 Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Updated test cases to work with the corrected check_all_clause_satisfaction: 1. Made FakeWorld.is_satisfied backward compatible: - Uses bounds_by_label for interval containment checks (new BUG-138 tests) - Falls back to truth_by_label for legacy tests 2. Updated existing test clauses to use proper 5-element structure: - Added clause_bnd and operator to match real clause structure - Updated: test_check_all_clause_satisfaction_calls_both_helpers_and_ands_results - Updated: test_check_all_clause_satisfaction_all_true_returns_true - Updated: test_check_all_clause_satisfaction_multiple_clauses_no_short_circuit 3. Simplified mock assertions to check call counts instead of exact arguments since qualified_groundings is now passed as second parameter All 142 tests now pass. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
dyumanaditya
approved these changes
Jan 29, 2026
Contributor
dyumanaditya
left a comment
dyumanaditya
left a comment
There was a problem hiding this comment.
looks good @ColtonPayne
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixed critical bug (Issue #98) in
check_all_clause_satisfactionwhere threshold checks were broken due to passing unfiltered groundings twice instead of properly filtering by clause bounds.Problem
BUG-138 (CRITICAL severity) affected threshold-based rule evaluation:
check_all_clause_satisfaction()was passinggroundings[clause_var_1]twice:This caused threshold checks to always compare the same set against itself, breaking both quantifier types:
"available" quantifier
qualified_count / available_counttotal_count / available_count"total" quantifier
qualified_count / total_counttotal_count / total_countSolution
Added proper filtering by clause bounds before threshold checking:
Changes
interpretation.py(lines 1237, 1242-1243, 1245-1247): Fixed threshold checking for both node and edge clausesinterpretation_fp.py(lines 1358, 1362-1363, 1365-1367): Applied same fix for consistencytest_ground_rule_helpers.py: Added comprehensive tests:test_check_all_clause_satisfaction_available_threshold_bug138test_check_all_clause_satisfaction_total_threshold_bug138Testing
Added two tests
test_check_all_clause_satisfaction_available_threshold_bug138andtest_check_all_clause_satisfaction_total_threshold_bug138to verify the initial behavior and that the fix aligns this with the intended behavior.Previous Interpretation - Failed tests
With Fixes - Tests pass
![Uploading Screenshot from 2026-01-26 08-28-28.png…]()
🤖 Generated with Claude Code