Skip to content

chore: bump golangci-lint to v2.11.4 and enable additional linters#686

Merged
porridge merged 5 commits intomainfrom
chore/bump-golangci-lint
May 7, 2026
Merged

chore: bump golangci-lint to v2.11.4 and enable additional linters#686
porridge merged 5 commits intomainfrom
chore/bump-golangci-lint

Conversation

@porridge
Copy link
Copy Markdown
Member

What this PR does / why we need it:

Bumps golangci-lint from v2.7.2 to v2.11.4 (adds Go 1.26 support, fixes panic: file requires newer Go version go1.26 error). Updates CI workflow to read Go version from go.mod instead of hardcoding 1.21 and bumps actions to v4/v5.

Enables 9 additional linters that pass with zero or minimal fixes: arangolint, depguard, embeddedstructfieldcheck, godoclint, godot, inamedparam, intrange, iotamixing, unqueryvet.

Annotates all 31 remaining disabled linters with issue-count summary comments.

Comment thread pkg/apis/testharness/v1beta1/test_types.go Outdated
Comment thread internal/harness/harness.go Outdated
porridge and others added 5 commits May 7, 2026 08:20
Update golangci-lint from v2.7.2 to v2.11.4 (adds Go 1.26 support).
Update CI workflow to read Go version from go.mod instead of hardcoding 1.21.
Bump GitHub Actions to current versions and add new linters to disabled list.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Marcin Owsiany <porridge@redhat.com>
Enable arangolint, depguard, godoclint, iotamixing, unqueryvet (no issues),
and embeddedstructfieldcheck (fixed 4 missing blank lines after embedded fields).

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Marcin Owsiany <porridge@redhat.com>
…led linters

Enable godot (comments must end in a period) and fix all comments.
Enable inamedparam (interface methods must have named parameters) and
add parameter names to DockerClient and Logger interfaces.
Add cyclop and depguard back to the disabled list.
Add issue-count summary comments to all disabled linters.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Marcin Owsiany <porridge@redhat.com>

# Conflicts:
#	internal/kubernetes/wait.go
Replace traditional C-style for loops with Go 1.22+ integer range syntax.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Marcin Owsiany <porridge@redhat.com>
Signed-off-by: Marcin Owsiany <porridge@redhat.com>
@porridge porridge force-pushed the chore/bump-golangci-lint branch from 1d02bab to 3577d7b Compare May 7, 2026 06:28
@porridge porridge merged commit fcf3736 into main May 7, 2026
6 checks passed
@porridge porridge deleted the chore/bump-golangci-lint branch May 7, 2026 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants