Skip to content

[release-0.95] Pin OVN-K to openshift release-4.17 for ipam e2e tests#2843

Open
RamLavi wants to merge 2 commits into
kubevirt:release-0.95from
RamLavi:fix-ipam-e2e-remove-ic-flag
Open

[release-0.95] Pin OVN-K to openshift release-4.17 for ipam e2e tests#2843
RamLavi wants to merge 2 commits into
kubevirt:release-0.95from
RamLavi:fix-ipam-e2e-remove-ic-flag

Conversation

@RamLavi

@RamLavi RamLavi commented Jun 25, 2026

Copy link
Copy Markdown
Collaborator

What this PR does / why we need it:

The ipam-controller e2e tests clone OVN-Kubernetes from upstream master to set up the kind cluster. OVN-K master has evolved significantly since Nov 2025 (including a Helm migration in Apr 2026), making it incompatible with the older ipam-extensions commit and KubeVirt v1.3.x pinned on this stable branch.

This PR pins OVN-K to openshift/ovn-kubernetes release-4.17, which matches the CNV 4.17 stack this stable branch targets.

Special notes for your reviewer:

The -ic (interconnect) flag is kept — it's valid on the release-4.17 branch. It was only removed on upstream master.

Release note:

NONE

@kubevirt-prow kubevirt-prow Bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jun 25, 2026
@kubevirt-prow kubevirt-prow Bot requested review from oshoval and qinqon June 25, 2026 05:29

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the end-to-end functional tests script for the kubevirt-ipam-controller by removing the -ic flag from the KIND_ARGS environment variable. I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@kubevirt-prow kubevirt-prow Bot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jun 25, 2026
@RamLavi RamLavi changed the title fix(ci): remove invalid -ic flag from kubevirt-ipam-controller e2e test [release-0.95] remove invalid -ic flag from kubevirt-ipam-controller e2e test Jun 25, 2026
@RamLavi

RamLavi commented Jun 25, 2026

Copy link
Copy Markdown
Collaborator Author

/approve

@kubevirt-prow kubevirt-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 25, 2026
@oshoval

oshoval commented Jun 25, 2026

Copy link
Copy Markdown
Collaborator

https://github.com/kubevirt/cluster-network-addons-operator/actions/runs/28149042935/job/83362352169?pr=2843

you sure it aint required on this old branch ?
lane fails

The ipam-controller e2e tests clone OVN-Kubernetes from master to set up
the kind cluster. OVN-K master has evolved significantly since Nov 2025
(including a Helm migration in Apr 2026), making it incompatible with the
older ipam-extensions commit and KubeVirt v1.3.x pinned on this branch.

Pin to openshift/ovn-kubernetes release-4.17, which matches the CNV 4.17
stack this stable branch targets.

Assisted-by: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Ram Lavi <ralavi@redhat.com>
@RamLavi RamLavi force-pushed the fix-ipam-e2e-remove-ic-flag branch from d21892f to 067c434 Compare June 25, 2026 09:55
@RamLavi RamLavi changed the title [release-0.95] remove invalid -ic flag from kubevirt-ipam-controller e2e test [release-0.95] Pin OVN-K to openshift release-4.17 for ipam e2e tests Jun 25, 2026
@RamLavi

RamLavi commented Jun 25, 2026

Copy link
Copy Markdown
Collaborator Author

/approve cancel

I need to discuss this approach with other maintainers

@kubevirt-prow

kubevirt-prow Bot commented Jun 25, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign phoracek for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-prow kubevirt-prow Bot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 25, 2026
The -ic (interconnect) flag enables OVN interconnect mode which causes
CoreDNS and other pods to get stuck in ContainerCreating on the
release-4.17 OVN-K branch, preventing cluster-up from completing.

Assisted-by: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Ram Lavi <ralavi@redhat.com>
@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
C Security Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@kubevirt-prow

kubevirt-prow Bot commented Jun 25, 2026

Copy link
Copy Markdown

@RamLavi: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-e2e-cnao-workflow-k8s-release-0.95 b3399c0 link true /test pull-e2e-cnao-workflow-k8s-release-0.95
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has DCO signed all their commits. release-note-none Denotes a PR that doesn't merit a release note. size/XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants