Skip to content

CI Failure: kubevirt/cluster-network-addons-operator/kubevirt-ipam-controller.yaml / The kubevirt-ipam-controller e2e test failed with "OCI_BIN:#2836

Open
RamLavi wants to merge 1 commit into
kubevirt:mainfrom
RamLavi:ai/issue-2835
Open

CI Failure: kubevirt/cluster-network-addons-operator/kubevirt-ipam-controller.yaml / The kubevirt-ipam-controller e2e test failed with "OCI_BIN:#2836
RamLavi wants to merge 1 commit into
kubevirt:mainfrom
RamLavi:ai/issue-2835

Conversation

@RamLavi

@RamLavi RamLavi commented Jun 24, 2026

Copy link
Copy Markdown
Collaborator

Fixes #2835

What this PR does / why we need it:

This PR fixes a CI failure in the kubevirt-ipam-controller e2e test that was failing with "OCI_BIN: unbound variable" error.

The root cause was the increase_ulimit() function checking ${OCI_BIN} without a default value while running with set -u enabled. This became an issue after the yq v4 upgrade removed the OCI_BIN initialization that was previously done for yq v3's container-based execution.

The fix uses ${OCI_BIN:-} syntax to provide an empty string default when OCI_BIN is unset, preventing the error while maintaining the correct conditional logic.

Special notes for your reviewer:

This is a one-line fix changing line 23 of automation/check-patch.e2e-kubevirt-ipam-controller-functests.sh from:

if [ -z "${OCI_BIN}" ];then

to:

if [ -z "${OCI_BIN:-}" ];then

The :- parameter expansion is the standard bash idiom for handling potentially unset variables when set -u is active.

Release note:

NONE

Related-to: kubevirt#2835

Fix OCI_BIN unbound variable error in kubevirt-ipam-controller test

The increase_ulimit() function in check-patch.e2e-kubevirt-ipam-controller-functests.sh
failed with "OCI_BIN: unbound variable" error when OCI_BIN was not set.

This was caused by the interaction of two changes:
1. The increase_ulimit() function used "${OCI_BIN}" without a default value
2. The yq v4 upgrade removed OCI_BIN initialization from yaml-utils.sh

The script runs with "set -u" which causes bash to exit when referencing
undefined variables. The fix uses "${OCI_BIN:-}" syntax to provide an empty
string default when OCI_BIN is unset, preventing the error while still
allowing the conditional check to work correctly.

Fixes kubevirt#2835

Signed-off-by: RamLavi <ralavi@redhat.com>
Assisted-by: Claude <noreply@anthropic.com>
@kubevirt-prow kubevirt-prow Bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Jun 24, 2026
@kubevirt-prow

kubevirt-prow Bot commented Jun 24, 2026

Copy link
Copy Markdown

Invalid commit message issues detected

Invalid commit messages

Keywords which can automatically close issues and hashtag(#) mentions are not allowed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@kubevirt-prow kubevirt-prow Bot requested a review from phoracek June 24, 2026 03:11
@kubevirt-prow

kubevirt-prow Bot commented Jun 24, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign phoracek for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-prow kubevirt-prow Bot requested a review from qinqon June 24, 2026 03:11

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the increase_ulimit function in the check-patch.e2e-kubevirt-ipam-controller-functests.sh script to safely handle the OCI_BIN variable when it is unbound by using the ${OCI_BIN:-} parameter expansion. There are no review comments to address.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. release-note-none Denotes a PR that doesn't merit a release note. size/XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CI Failure: kubevirt/cluster-network-addons-operator/kubevirt-ipam-controller.yaml / The kubevirt-ipam-controller e2e test failed with "OCI_BIN:

1 participant