CI Failure: kubevirt/cluster-network-addons-operator/kubevirt-ipam-controller.yaml / The kubevirt-ipam-controller e2e test failed with "OCI_BIN:#2836
Conversation
Related-to: kubevirt#2835 Fix OCI_BIN unbound variable error in kubevirt-ipam-controller test The increase_ulimit() function in check-patch.e2e-kubevirt-ipam-controller-functests.sh failed with "OCI_BIN: unbound variable" error when OCI_BIN was not set. This was caused by the interaction of two changes: 1. The increase_ulimit() function used "${OCI_BIN}" without a default value 2. The yq v4 upgrade removed OCI_BIN initialization from yaml-utils.sh The script runs with "set -u" which causes bash to exit when referencing undefined variables. The fix uses "${OCI_BIN:-}" syntax to provide an empty string default when OCI_BIN is unset, preventing the error while still allowing the conditional check to work correctly. Fixes kubevirt#2835 Signed-off-by: RamLavi <ralavi@redhat.com> Assisted-by: Claude <noreply@anthropic.com>
|
Invalid commit message issues detected Invalid commit messagesKeywords which can automatically close issues and hashtag(#) mentions are not allowed.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Code Review
This pull request updates the increase_ulimit function in the check-patch.e2e-kubevirt-ipam-controller-functests.sh script to safely handle the OCI_BIN variable when it is unbound by using the ${OCI_BIN:-} parameter expansion. There are no review comments to address.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|



Fixes #2835
What this PR does / why we need it:
This PR fixes a CI failure in the kubevirt-ipam-controller e2e test that was failing with "OCI_BIN: unbound variable" error.
The root cause was the
increase_ulimit()function checking${OCI_BIN}without a default value while running withset -uenabled. This became an issue after the yq v4 upgrade removed the OCI_BIN initialization that was previously done for yq v3's container-based execution.The fix uses
${OCI_BIN:-}syntax to provide an empty string default when OCI_BIN is unset, preventing the error while maintaining the correct conditional logic.Special notes for your reviewer:
This is a one-line fix changing line 23 of
automation/check-patch.e2e-kubevirt-ipam-controller-functests.shfrom:to:
The
:-parameter expansion is the standard bash idiom for handling potentially unset variables whenset -uis active.Release note: