components: Pin linux-bridge version#1777
Conversation
Use plugins latest release v1.44.1 [1] [1] https://github.com/containernetworking/plugins/releases/tag/v1.4.1 Signed-off-by: Or Mergi <ormergi@redhat.com>
kubevirt-bot
added
release-note-none
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/cc @RamLavi |
|
|
@ormergi: The following tests failed, say
DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
| channels: | ||
| - name: alpha | ||
| currentCSV: cluster-network-addons-operator.0.90.1 | ||
| currentCSV: cluster-network-addons-operator.99.0.0 |
There was a problem hiding this comment.
i dont think it is related to the PR ?
| manifest_registry=$DEV_IMAGE_REGISTRY | ||
| push_registry=$manifest_registry | ||
| manifest_registry=$DEV_MANIFEST_REGISTRY | ||
| push_registry=$DEV_IMAGE_REGISTRY |
There was a problem hiding this comment.
it also not related to the PR scope
even if we need to fix stuff about those vars, lets do it on a separate PR please and all the way ?
this does work atm fwiw
export KUBEVIRT_PROVIDER=external
export DEV_IMAGE_REGISTRY=quay.io/oshoval
| users: | ||
| - system:serviceaccount:kube-system:passt-binding-cni | ||
| volumes: | ||
| - "*" No newline at end of file |
There was a problem hiding this comment.
missing new line
I think we need please to wrap with SCC enabled, as we have on data/linux-bridge/001-rbac.yaml
(also the SA user as done on DS)
i think we should move this also to 001-rbac please, it is better practice it is created before the DS
(anyhow we are eventually consistent), and all the SA / SCC are there already
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
kubevirt-bot
added
the
needs-rebase
|
@ormergi what's the status on this PR? |
|
@ormergi I'm closing this PR. If you need it again, feel free to reopen :) |
|
Sorry for late response, I still think it worth working on it I will post new PR as soon as I have capacity 🙂 |
4 participants
What this PR does / why we need it:
Follow-up to #1767
Use plugins latest release v1.44.1 [1] for linux-bridge component.
[1] https://github.com/containernetworking/plugins/releases/tag/v1.4.1
Special notes for your reviewer:
Release note: